Windows gfx1201 #1500
Open
Windows gfx1201 #1500
+1,450
−182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amd-mtrifuno
requested review from
jichangjichang,
KKyang,
vin-huang,
imcarsonliao,
hcman2,
Serge45,
Jinp800125,
TonyYHsieh and
solaslin
as code owners
amd-mtrifuno
force-pushed
the
windows_gfx1201
branch
from
d9083e6 to
1a179d5
Compare
amd-mtrifuno
force-pushed
the
windows_gfx1201
branch
from
1a179d5 to
73e19e4
Compare
|
Please rebase and fix the conflicts. |
Done. |
Serge45
reviewed
Feb 25, 2025
|
|
||
| runScriptFile.write(callCreateLibraryCmd) | ||
| return callCreateLibraryCmd |
There was a problem hiding this comment.
There's some issues here and causes tox tests failure on gfx942:
- the return type was changed to
list, but the caller treats it as string(refer to L101). - mixing concatenating
listandstr, which may generate unexpected result if you want to simply join them.
You can run tox test locally to reproduce the error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.