SWDEV000000 - Migrate architecture specific intrinsics to SIMDe #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iassiour
reviewed
Jun 4, 2025
| @@ -142,19 +142,20 @@ __hip_pch_wave64_size: | |||
| .long __hip_pch_wave64_size - __hip_pch_wave64 | |||
| EOF | |||
|
|
|||
| host_triple="$(uname -m)" | |||
There was a problem hiding this comment.
I think this will return x86_64 (or aarch64 on arm) but don't we need the full triple i.e. x86_64-unknown-linux-gnu or aarch64-linux-gnu?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated JIRA ticket number/Github issue number
None.
What type of PR is this? (check all applicable)
What were the changes?
Existing unguarded uses of x86 intrinsics are replaced with equivalent calls to generic interfaces provided by the SIMDe library. SIMDe itself is added as a build dependency
Why are these changes needed?
Direct, unguarded use of architecture specific intrinsics / builtins creates challenges both when studying the library's behaviour on non-x86 targets, and when exploring different OSes.
Updated CHANGELOG?
Added/Updated documentation?
Additional Checks