Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing set_device calls for nvidia_transform #52

Open
wants to merge 1 commit into
base: rocm_enabled_multi_backend
Choose a base branch
from
Open

Added missing set_device calls for nvidia_transform #52

wants to merge 1 commit into from

Conversation

Serge45
Copy link

@Serge45 Serge45 commented Nov 13, 2024

In HIP_ENVIRONMENT is True case, there's missing calls of pre_call and post_call for proper device setting for nvidia_transform.

@pnunna93 pnunna93 requested a review from lcskrishna January 2, 2025 21:53
@lcskrishna lcskrishna self-requested a review January 3, 2025 05:18
@lcskrishna
Copy link

lcskrishna commented Jan 3, 2025 •
edited
Loading

@pnunna93 @Serge45 Please verify if we need to add the corner cases when state=none and out=none similar to without HIP. If there is no need, the PR is fine for merge.

@pnunna93
Copy link
Collaborator

pnunna93 commented Jan 3, 2025

They are present in nvidia_transform - https://github.com/Serge45/bitsandbytes/blob/feature/miss-set-device-transform/bitsandbytes/functional.py#L516-L520

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcskrishna lcskrishna Awaiting requested review from lcskrishna

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Serge45 @lcskrishna @pnunna93