Move test_perf.py from bin dir #3667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cderb
requested review from
BrianHarrisonAMD,
BradPepersAMD,
adickin-amd and
JonathanLichtnerAMD
as code owners
BrianHarrisonAMD
approved these changes
Apr 3, 2025
nunnikri
requested changes
Apr 3, 2025
test/CMakeLists.txt
Outdated
| option( MIOPEN_TEST_DBSYNC "" OFF ) | ||
| option( MIOPEN_TEST_PERF "" OFF ) | ||
|
|
||
| if(MIOPEN_TEST_PERF) |
There was a problem hiding this comment.
Its safer to add ASAN condition . And same check is needed in line no #39. We dont need to package share folder for asan package
if( NOT ENABLE_ASAN_PACKAGING )
There was a problem hiding this comment.
added asan package condition to cmake
nunnikri
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move test_perf.py to prevent overlap in rocm bin dir.
cmake flag for installing test_perf.py
https://ontrack-internal.amd.com/browse/SWDEV-522566