Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for CMake generators when installing dependencies. #3619

Merged
merged 3 commits into from
Apr 11, 2025
Merged

Add support for CMake generators when installing dependencies. #3619

merged 3 commits into from
Apr 11, 2025

Conversation

amd-jmacaran
Copy link
Contributor

  • cget tool supports -G parameter to specify generator. Reference
  • This code change provides capability to leverage that support and let user pick a generator with install_deps.cmake, limiting to Ninja or Unix Makefiles at the moment.
  • Example Usage: cmake -P install_deps.cmake --prefix $(HOME))/miopen-deps --generator Ninja
  • Trial run on Azure VM with 64 cores cut down execution time of this script by a few minutes. Pipeline Log

@amd-jmacaran amd-jmacaran self-assigned this Mar 14, 2025
DrizztDoUrden
DrizztDoUrden previously requested changes Mar 17, 2025
View reviewed changes
BrianHarrisonAMD
BrianHarrisonAMD approved these changes Apr 11, 2025
View reviewed changes
Copy link
Contributor

@BrianHarrisonAMD BrianHarrisonAMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amd-jmacaran amd-jmacaran dismissed DrizztDoUrden’s stale review April 11, 2025 15:20

Suggestions were applied and a code-owner has done a review.

@amd-jmacaran amd-jmacaran merged commit a4abbf7 into develop Apr 11, 2025
25 of 76 checks passed
@amd-jmacaran amd-jmacaran deleted the jmacaran/generatorDependencies branch April 11, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrianHarrisonAMD BrianHarrisonAMD BrianHarrisonAMD approved these changes

@danielsu-amd danielsu-amd danielsu-amd approved these changes

@BradPepersAMD BradPepersAMD Awaiting requested review from BradPepersAMD BradPepersAMD is a code owner

@adickin-amd adickin-amd Awaiting requested review from adickin-amd adickin-amd is a code owner

@JonathanLichtnerAMD JonathanLichtnerAMD Awaiting requested review from JonathanLichtnerAMD JonathanLichtnerAMD is a code owner

@DrizztDoUrden DrizztDoUrden Awaiting requested review from DrizztDoUrden

Assignees

@amd-jmacaran amd-jmacaran

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amd-jmacaran @DrizztDoUrden @BrianHarrisonAMD @danielsu-amd