2D and 3D NGCHW forward convolution solvers based on CK instances #3616
+1,336
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iq136boy
requested review from
BrianHarrisonAMD,
BradPepersAMD,
adickin-amd and
JonathanLichtnerAMD
as code owners
|
@iq136boy Please add also |
| #if MIOPEN_BACKEND_HIP && MIOPEN_USE_COMPOSABLEKERNEL | ||
|
|
||
| using InLayoutNCHW = ck::tensor_layout::convolution::NGCDHW; | ||
| using WeiLayout = ck::tensor_layout::convolution::GKZYXC; |
There was a problem hiding this comment.
Layout for the weights needs to be GKCZYX (same as WRW)
Comment on lines
145
to
149
| wei_lengths = {G, K, C, Z, Y, X}; | ||
|
|
||
| in_strides = {Di * Hi * Wi * C, Di * Hi * Wi * G * C, Di * Hi * Wi, Hi * Wi, Wi, 1}; | ||
| out_strides = {Do * Ho * Wo * K, Do * Ho * Wo * G * K, Do * Ho * Wo, Ho * Wo, Wo, 1}; | ||
| wei_strides = {K * Z * Y * X * C, Z * Y * X * C, 1, Y * X * C, X * C, C}; |
There was a problem hiding this comment.
Just reminder to flip lengths and strides once layout changes.
There was a problem hiding this comment.
Also, very surprised this isn't causing errors.
Looks like we are assuming the data is in NHWC layout, but it'll come in as NCHW layout from MIOpen side.
|
I think we need to double check the verification is working properly for these tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement 2d and 3d NGCHW forward convolution solvers base on CK NGCHW layout instances.
The solver utilize the fused CK convolution and layout transform kernels to avoid the tensor layout transform in MIOpen side.