-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Softmax #3607
base: develop
Are you sure you want to change the base?
Implement Softmax #3607
Conversation
uint32_t dim, | ||
miopenSoftmaxAlgorithm_t algorithm) | ||
{ | ||
MIOPEN_LOG_FUNCTION(inputDesc, input, outputDesc, output, dim, algorithm); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No LogCmdSoftmax
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
V3 only supports MIOPEN_SOFTMAX_MODE_OPTIONAL_DIM
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No
LogCmdSoftmax
?
LogCmdSoftmax
is mainly used for debugging, so is it optional? I think MIOPEN_LOG_FUNCTION
is sufficient for debugging purposes.
V3 only supports
MIOPEN_SOFTMAX_MODE_OPTIONAL_DIM
?
Yes, MIOPEN_SOFTMAX_MODE_OPTIONAL_DIM
is more general than MIOPEN_SOFTMAX_MODE_CHANNEL
so it just doesn't support MIOPEN_SOFTMAX_MODE_INSTANCE
Average improvement over ROCm
Detail Benchmark
float16
float32
bfloat16