boards/olimexino-stm32f3: add board definition #21806
Open
+29,348
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Platform: ARM
maribu
force-pushed
the
boards/olimexino-stm32f3
branch
from
562c48f to
9507f43
Compare
crasbe
added
Type: new feature
crasbe
requested changes
Oct 19, 2025
Comment on lines
+22
to
+26
| /* This board provides an LSE */ | ||
| #ifndef CONFIG_BOARD_HAS_LSE | ||
| # define CONFIG_BOARD_HAS_LSE 1 | ||
| #endif | ||
|
|
||
| /* This board provides an HSE */ | ||
| #ifndef CONFIG_BOARD_HAS_HSE | ||
| # define CONFIG_BOARD_HAS_HSE 1 | ||
| #endif |
There was a problem hiding this comment.
Not sure these defines need an #ifndef block tbh. That's not something you would actually change?
There was a problem hiding this comment.
It would at least be possible to disabled the use of the external crystals.
Other than reproducing an issue that only triggers on boards without external crystals when having only this board at hand, I do not have a use case.
This matches what other boards do, though. It might be better to keep it consistent for now and have this discussion for all boards.
|
Perhaps you can (temporarily) change the |
maribu
force-pushed
the
boards/olimexino-stm32f3
branch
from
63b2f82 to
8e960c6
Compare
This reduces false positives for included but not directly used headers.
This USB peripheral seems to not be clocked when entering IDLE, at least on STM32F3. Given that an increase of power consumption in the order of 10s of mA is usually of little concern when powered via USB, this just disables the idle power state for all STM32 MCUs when USB is in use to rather err on the side of additional power draw, rather than broken USB.
maribu
force-pushed
the
boards/olimexino-stm32f3
branch
from
8e960c6 to
145fd81
Compare
kaspar030
reviewed
Oct 20, 2025
| /* Block STOP/STANDBY */ | ||
| pm_block(STM32_PM_STOP); | ||
| pm_block(STM32_PM_STANDBY); | ||
| pm_block(STM32_PM_IDLE); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
tests/periph/timerwith the Olimexino-STM32F3 when usingstdio_usb_cdc_acmTesting procedure
tests/basic/defaultruns with USB and both LEDs and the BOOT button work with thesaulshell commandtests/periph/timerpasses, confirming the timer config is correctIssues/PRs references
None