build-system: pin new docker image #21531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that `make BUILD_IN_DOCKER=1` will use the same container that was used in the CI (Murdock).
maribu
added
Impact: minor
chrysn
added a commit
to chrysn-pull-requests/riotdocker
that referenced
this pull request
Jun 4, 2025
Trouble with [21531] indicates that running tests on native is insufficient to catch native32 trouble; this should catch that kind of issue earlier. [21531]: RIOT-OS/RIOT#21531
chrysn
added a commit
to chrysn-pull-requests/riotdocker
that referenced
this pull request
Jun 4, 2025
Trouble with [21531] indicates that running tests on native is insufficient to catch native32 trouble; this should catch that kind of issue earlier. [21531]: RIOT-OS/RIOT#21531
|
That's weird -- admittedly, the riotbuild tests only run on native and not separately on native32 and native64, but I can't remember ever having had differentiated issues. Checking that is now blocked 3 issues deep: this one would be addressed by RIOT-OS/riotdocker#261 but that's stuck as it needs RIOT-OS/riotdocker#256 but that needs some cleanup after #21359 |
|
@maribu a way to break the CI-stuck loop would be to blacklist |
github-actions
bot
added
Platform: native
crasbe
added
Type: bug
mguetschow
approved these changes
Jun 4, 2025
Until the bug is fixed
maribu
force-pushed
the
makefiles/docker.inc.mk/pin-new-image
branch
from
77bd10d to
0a21b4d
Compare
github-actions
bot
added
Area: examples
|
Backport provided in #21541 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This ensures that
make BUILD_IN_DOCKER=1will use the same container that was used in the CI (Murdock).Testing procedure
Green CI
Issues/PRs references
None