Start testing the script... #33
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrKevinWeiss
force-pushed
the
pr/addtesting
branch
from
2af3835 to
6a89050
Compare
|
Note that there is also https://github.com/RIOT-OS/RIOT-release-manager/tree/tests which I never managed to bring into full working order. |
|
I wasn't aware of it, We can probably expand but I think just doing some simple doctests is a clean and maintainable way to start. |
|
Yepp, just wanted to point out, that there was work already done and that it can be picked up, if anyone desires to :-). |
|
@MrKevinWeiss can you rebase, please? |
MrKevinWeiss
force-pushed
the
pr/addtesting
branch
from
6a89050 to
6131e43
Compare
MrKevinWeiss
commented
Dec 11, 2024
Comment on lines
+143
to
+144
| merge_lines = [line for line in log.splitlines() if line.strip().startswith('Merge #')] | ||
| return [int(line) for line in re.findall(r"#([0-9]+)", '\n'.join(merge_lines))] |
There was a problem hiding this comment.
I wonder if this is still valid since
There was a problem hiding this comment.
Probably should now be
Suggested change
| merge_lines = [line for line in log.splitlines() if line.strip().startswith('Merge #')] | |
| return [int(line) for line in re.findall(r"#([0-9]+)", '\n'.join(merge_lines))] | |
| return [int(line["PR"]) for line in re.findall(r"(Merge pull request|Merge) #(?P<PR>[0-9]+)"), log] |
this way we are also backwards compatible with bors based PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds CI and reworks a simple doctest