-
Notifications
You must be signed in to change notification settings - Fork 5
Add new Strimzi operated charts for the Kafka connectors #4474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
1c2fee6 to
e9756d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are several issues that need discussion:
- Removal of legacy config and persistence features from strimzi connector
- Use of the name radar-fitbit-connector-strimzi
- Cleanup of the _helpers.tpl file
| apiVersion: v2 | ||
| appVersion: 3.9.0 | ||
| description: A Helm chart for RADAR-base fitbit Kafka connector using the Strimzi Operator. This application collects data from participants via the Fitbit Web API. | ||
| name: radar-fitbit-connector-strimzi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This name works, but we need to change the release name in RADAR-Kubernets to the same name or else I get an error due to a too long name for a resource.
| {{/* | ||
| Expand the name of the chart. | ||
| */}} | ||
| {{- define "radar-fitbit-connector-strimzi.name" -}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One other thing I would like to make a start with is to reduce the redundancy we have for the functions in the _helpers.tpl file and the commons chart dependency. For instance in _helpers.tpl the name function is identical to the commons.names.name function. Would it possible to do a side by side comparison of these files and remove the duplicates?
6804baf to
650a7a0
Compare
33da29e to
015c079
Compare
| appVersion: 3.9.0 | ||
| description: A Helm chart for RADAR-base s3 connector. This connector uses Confluent s3 connector with a custom data transformers. These configurations enable a sink connector. See full list of properties here https://docs.confluent.io/kafka-connect-s3-sink/current/configuration_options.html#s3-configuration-options | ||
| name: radar-s3-connector-strimzi | ||
| version: 0.7.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to align better on the new *-strimzi charts versions. For some of them the versioning is continued from a previous connector chart, for some it starts over from 0.0.1
Strimzi is an operator for Kafka and Kafka connectors (see https://strimzi.io/).
It supports running Kafka connectors in distributed mode.
This PR will:
New charts:
Depends on: