Skip to content

Conversation

@ewelinagr
Copy link
Contributor

@ewelinagr ewelinagr commented Jul 2, 2025

Strimzi is an operator for Kafka and Kafka connectors (see https://strimzi.io/).
It supports running Kafka connectors in distributed mode.
This PR will:

  • Add a new chart for the Strimzi operated Kafka connectors (suffixed with *-strimzi).
  • Deprecate existing connector charts (not operated by Strimzi)

New charts:

  • radar-fitbit-connector-strimzi
  • radar-oura-connector-strimzi
  • radar-s3-connector-strimzi
  • radar-jdbc-connector-strimzi
  • radar-upload-source-connector-strimzi

Depends on:

@ewelinagr ewelinagr requested a review from pvannierop July 2, 2025 08:43
@github-actions
Copy link

github-actions bot commented Jul 2, 2025

Great PR! Please pay attention to the following items before merging:

Files matching charts/*/values.yaml:

  • Is the PR adding a new container? Please reviewer, add it to the models (internal process)
  • Is the PR adding a new parameter? Please, ensure it’s documented in the README.md

This is an automatically generated QA checklist based on modified files.

@pvannierop pvannierop force-pushed the feature/strimzi-operator-connector-chart branch from 1c2fee6 to e9756d6 Compare July 2, 2025 11:28
Copy link
Contributor

@pvannierop pvannierop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are several issues that need discussion:

  • Removal of legacy config and persistence features from strimzi connector
  • Use of the name radar-fitbit-connector-strimzi
  • Cleanup of the _helpers.tpl file

apiVersion: v2
appVersion: 3.9.0
description: A Helm chart for RADAR-base fitbit Kafka connector using the Strimzi Operator. This application collects data from participants via the Fitbit Web API.
name: radar-fitbit-connector-strimzi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This name works, but we need to change the release name in RADAR-Kubernets to the same name or else I get an error due to a too long name for a resource.

{{/*
Expand the name of the chart.
*/}}
{{- define "radar-fitbit-connector-strimzi.name" -}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One other thing I would like to make a start with is to reduce the redundancy we have for the functions in the _helpers.tpl file and the commons chart dependency. For instance in _helpers.tpl the name function is identical to the commons.names.name function. Would it possible to do a side by side comparison of these files and remove the duplicates?

@ewelinagr ewelinagr force-pushed the feature/strimzi-operator-connector-chart branch from 6804baf to 650a7a0 Compare July 3, 2025 09:22
@pvannierop pvannierop force-pushed the feature/strimzi-operator-connector-chart branch from 33da29e to 015c079 Compare July 3, 2025 14:24
@ewelinagr ewelinagr changed the title [radar-fitbit-connector] Implement Strimzi Operator for the Fitbit connector. Add new Strimzi operated charts for the Kafka connectors Jul 4, 2025
appVersion: 3.9.0
description: A Helm chart for RADAR-base s3 connector. This connector uses Confluent s3 connector with a custom data transformers. These configurations enable a sink connector. See full list of properties here https://docs.confluent.io/kafka-connect-s3-sink/current/configuration_options.html#s3-configuration-options
name: radar-s3-connector-strimzi
version: 0.7.1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to align better on the new *-strimzi charts versions. For some of them the versioning is continued from a previous connector chart, for some it starts over from 0.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants