Release 3.3.4-alpha #1858

mpgxvii · 2025-02-14T15:10:57Z

Allow task info visibility to be configurable in remote config (needed for studies where showing the number of questions and est time of completion of a task is not necessary)
Also allow slider and yesno input to be a matrix type (allow showing multiple slider questions in one page)
Update date input to be DD/MM/YYYY format
Add explicit check for changes in MP participant attributes (for changes in protocol, etc)
Ensure storage service is ready before app initialisation
Decode iat in token if not present in response (e.g. for ory tokens)
Fixed schema versions persisting even when enrolling on a separate platform instance
Add iOS Privacy Manifest (required for new updates)
Update dependencies

Various updates

yatharthranjan

Thanks. Mostly looks good to me. Just some minor comments below.

yatharthranjan · 2025-02-14T16:27:04Z

src/app/pages/home/services/tasks.service.ts

@@ -127,6 +128,10 @@ export class TasksService {
    return task.completed && this.isToday(task.timeCompleted)
  }

+  wasTaskValidToday(task) {
+    return this.isToday(task.timestamp)


what is the reason for this check?

will this still work if completion window is long, so the task timestamp is before today?

I added the check to the getTasks method:

RADAR-Questionnaire/src/app/pages/home/services/tasks.service.ts

Line 69 in 0d57afa

t => !this.isTaskExpired(t) || this.wasTaskCompletedToday(t) || this.wasTaskValidToday(t)

It will check if the task is not expired (if the completion window is long), if the task was completed today, and if the task was valid today. This was to keep expired tasks if they were valid in the same day to keep track of task progress of the day. Otherwise, they are not included in the day's progress.

yatharthranjan · 2025-02-14T16:35:00Z

src/app/pages/questions/containers/questions-page.component.ts

@@ -281,7 +287,7 @@ export class QuestionsPageComponent implements OnInit {
    const currentQs = this.getCurrentQuestions()
    if (!currentQs) return
    this.isRightButtonDisabled =
-      !this.questionsService.isAnyAnswered(currentQs) &&
+      !this.questionsService.areAllAnswered(currentQs) &&
      !this.questionsService.getIsAnyNextEnabled(currentQs)


Could there be cases even in matrix types where some questions are required but some are optional on the same page?

Yes, but we currently don't support whether individual questions are required. They are configured per input type. But yes we can add support for this since it is a field in the Redcap questionnaire.

yatharthranjan · 2025-02-14T16:36:21Z

src/app/pages/questions/components/question/text-input/text-input.component.ts

  value = {}
+  DEFAULT_DATE_FORMAT = 'DD/MM/YYYY'


I think this is enough for now, but would be good to do this via remote config (or protocol). Please create an issue so it can be handled later.

Added here: #1859

yatharthranjan · 2025-02-18T15:19:50Z

ios/App/App/Info.plist

@@ -83,5 +83,10 @@
 	</array>
 	<key>UIViewControllerBasedStatusBarAppearance</key>
 	<true/>
+  <key>NSAppTransportSecurity</key>
+  <dict>
+  <key>NSAllowsArbitraryLoads</key>


what is this needed for (http urls?). I assume this will this be less secure?
If required i would like this to be configurable per project like we do in the pRMT app through remote config (by default it should be secure option)

Ah yes I was just copying this from the dev branch because I thought it was needed. Removed now.

Add iOS privacy manifest

mpgxvii added 20 commits February 14, 2025 02:21

Add reset for schemas and converters

8eeeb14

Allow task info to be hidden

8817457

Allow slider to be a matrix type

3a273b1

Add healthkit to QuestionType

c1426f6

Check matrix group name exists before grouping

4dc7544

Check all questions are answered in matrix

2cfda7c

Allow yesno input to be a matrix question

0ec29c9

Update date input to use dd/mm/yyyy format

d1d1d47

Update task service

2944ebb

Update xcode project file

49bce10

Update enrolment page change detection

7ca0f2a

Ensure storage service is ready before init

6fcfde2

Cleanup

e6f7b6f

Decode iat in token if not present in response

02b69e0

Cleanup

cc0a05e

Enrolment page improvements

065214f

Add explicit check for changes in participant attributes

ab7aedd

Remove unnecessary check in participant attributes

0b251a7

Bump versions

e601465

Merge pull request #1857 from RADAR-base/feat/various-updates

0d57afa

Various updates

mpgxvii requested a review from yatharthranjan February 14, 2025 15:10

yatharthranjan reviewed Feb 14, 2025

View reviewed changes

mpgxvii added 5 commits February 17, 2025 17:41

Fix matrix radio input

8dc2e68

Update ios Info.plist

5aecd14

Remove unnecessary loading var update

265d22b

Bump deprecated actions

60da91e

Bump deprecated actions

6be293a

yatharthranjan reviewed Feb 18, 2025

View reviewed changes

mpgxvii added 2 commits February 18, 2025 15:42

Update Info.plist

a2031c9

Add iOS privacy manifest

70846f7

mpgxvii added 4 commits February 18, 2025 16:45

Update privacy manifest: remove duplicates

828f695

Update privacy manifest

0627244

Merge pull request #1860 from RADAR-base/add-privacy-manifest

2a82403

Add iOS privacy manifest

Bump versions and update ios files

098d7bd

mpgxvii merged commit d4c85b4 into master Feb 19, 2025
4 checks passed

mpgxvii deleted the release-3.3.4-alpha2 branch February 19, 2025 11:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release 3.3.4-alpha #1858

Release 3.3.4-alpha #1858

mpgxvii commented Feb 14, 2025 •

edited

Loading

yatharthranjan left a comment

yatharthranjan Feb 14, 2025

yatharthranjan Feb 14, 2025

mpgxvii Feb 17, 2025

yatharthranjan Feb 14, 2025

mpgxvii Feb 17, 2025

yatharthranjan Feb 14, 2025

mpgxvii Feb 17, 2025

yatharthranjan Feb 18, 2025

mpgxvii Feb 18, 2025

Release 3.3.4-alpha #1858

Release 3.3.4-alpha #1858

Conversation

mpgxvii commented Feb 14, 2025 • edited Loading

yatharthranjan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mpgxvii commented Feb 14, 2025 •

edited

Loading