Skip to content

Conversation

@JerryWu1234
Copy link
Contributor

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos
  • Infra

Description

error TS2321: Excessive stack depth comparing types 'QwikVitePlugin' and 'Plugin$1'.

137 qwikPlugin = config.plugins.find((p) => p.name === 'vite-plugin-qwik') as QwikVitePlugin;
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Found 1 error in packages/qwik-router/src/buildtime/vite/plugin.ts:137

❌ Error: Command failed with exit code 2: tsc -p /Users/gwm/Desktop/github/qwik/packages/qwik-router/tsconfig.json
at makeError (file:///Users/gwm/Desktop/github/qwik/node_modules/.pnpm/[email protected]/node_modules/execa/lib/error.js:60:11)
at handlePromise (file:///Users/gwm/Desktop/github/qwik/node_modules/.pnpm/[email protected]/node_modules/execa/index.js:124:26)
at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
at async tscQwikRouter (/Users/gwm/Desktop/github/qwik/scripts/tsc.ts:18:18)
at async build (/Users/gwm/Desktop/github/qwik/scripts/build.ts:110:7) {
shortMessage: 'Command failed with exit code 2: tsc -p /Users/gwm/Desktop/github/qwik/packages/qwik-router/tsconfig.json',
command: 'tsc -p /Users/gwm/Desktop/github/qwik/packages/qwik-router/tsconfig.json',
escapedCommand: 'tsc -p "/Users/gwm/Desktop/github/qwik/packages/qwik-router/tsconfig.json"',
exitCode: 2,
signal: undefined,
signalDescription: undefined,
stdout: undefined,
stderr: '',
cwd: '/Users/gwm/Desktop/github/qwik',
failed: true,
timedOut: false,
isCanceled: false,
killed: false
}

fixed this type error

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

@JerryWu1234 JerryWu1234 requested a review from a team as a code owner September 26, 2025 07:32
@changeset-bot
Copy link

changeset-bot bot commented Sep 26, 2025

⚠️ No Changeset found

Latest commit: bd3925a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 26, 2025

Open in StackBlitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@8001
npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@8001
npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@8001
npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@8001

commit: bd3925a

@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview bd3925a

Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

Copy link
Member

@maiieul maiieul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @JerryWu1234 👊

@maiieul maiieul merged commit 2b27088 into QwikDev:build/v2 Sep 27, 2025
20 checks passed
@maiieul maiieul moved this from Backlog to Done in Qwik Development Sep 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants