-
Couldn't load subscription status.
- Fork 1.4k
refactor(router): improve plugin retrieval logic in Vite adapter #8001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
commit: |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
… depth error in plugin retrieval
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @JerryWu1234 👊
What is it?
Description
error TS2321: Excessive stack depth comparing types 'QwikVitePlugin' and 'Plugin$1'.
137 qwikPlugin = config.plugins.find((p) => p.name === 'vite-plugin-qwik') as QwikVitePlugin;
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Found 1 error in packages/qwik-router/src/buildtime/vite/plugin.ts:137
❌ Error: Command failed with exit code 2: tsc -p /Users/gwm/Desktop/github/qwik/packages/qwik-router/tsconfig.json
at makeError (file:///Users/gwm/Desktop/github/qwik/node_modules/.pnpm/[email protected]/node_modules/execa/lib/error.js:60:11)
at handlePromise (file:///Users/gwm/Desktop/github/qwik/node_modules/.pnpm/[email protected]/node_modules/execa/index.js:124:26)
at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
at async tscQwikRouter (/Users/gwm/Desktop/github/qwik/scripts/tsc.ts:18:18)
at async build (/Users/gwm/Desktop/github/qwik/scripts/build.ts:110:7) {
shortMessage: 'Command failed with exit code 2: tsc -p /Users/gwm/Desktop/github/qwik/packages/qwik-router/tsconfig.json',
command: 'tsc -p /Users/gwm/Desktop/github/qwik/packages/qwik-router/tsconfig.json',
escapedCommand: 'tsc -p "/Users/gwm/Desktop/github/qwik/packages/qwik-router/tsconfig.json"',
exitCode: 2,
signal: undefined,
signalDescription: undefined,
stdout: undefined,
stderr: '',
cwd: '/Users/gwm/Desktop/github/qwik',
failed: true,
timedOut: false,
isCanceled: false,
killed: false
}
fixed this type error
Checklist
pnpm change