Skip to content

chore(eslint): add warning when using async preventDefault() #7723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Shane-Donlon
Copy link
Contributor

What is it?

Description

eslint rule showing error this is an asynchronous function and does not support preventDefault.
Use preventDefault attributes instead

Hey guys,
Feedback welcome - but thought I'd propose this as an idea.

While the knowledge exists in the documentation, the goal here is to prompt Developers that this is not a bug and to search the docs or to ask within Discord.

This does exclude sync$((e)=>{e.preventDefault()} functions, and I did add this as a warning over error just in case there was something else I wasn't considering, and wouldn't result in breaking any builds.

eslint rule for sync function not showing error

Checklist

@Shane-Donlon Shane-Donlon requested a review from a team as a code owner July 11, 2025 23:01
Copy link

changeset-bot bot commented Jul 11, 2025

⚠️ No Changeset found

Latest commit: 182c859

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Jul 11, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@builder.io/qwik@7723
npm i https://pkg.pr.new/@builder.io/qwik-city@7723
npm i https://pkg.pr.new/eslint-plugin-qwik@7723
npm i https://pkg.pr.new/create-qwik@7723

commit: 182c859

Copy link
Contributor

github-actions bot commented Jul 11, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 182c859

Copy link
Contributor

@maiieul maiieul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good idea 🔥 Thanks a lot @Shane-Donlon!

},
messages: {
noAsyncPreventDefault:
'This is an asynchronous function and does not support preventDefault. \nUse preventDefault attributes instead',
Copy link
Contributor

@maiieul maiieul Jul 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a link to the docs? Also I think this should suggest the use of sync$ too. WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants