fix(vite): the @qwik-handlers aren't properly handled in dev mode for library projects - #7608
Merged
Merged
Conversation
Contributor
Author
|
commit: |
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
JerryWu1234
marked this pull request as ready for review
May 19, 2025 05:20
JerryWu1234
changed the title
🦋 Changeset detectedLatest commit: 2aaa772 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
wmertens
reviewed
May 20, 2025
Update the version bump in the changeset file from 'major' to 'patch' to reflect the correct severity of the fix for @qwik-handlers in dev mode for library projects.
wmertens
requested changes
Jun 2, 2025
The opts initialization was moved inside the async plugin function to ensure proper handling of options during dev mode. This fixes an issue where @qwik-handlers weren't properly handled in dev mode for library projects, as referenced in issue QwikDev#7600.
Member
|
This is blocking Jerry. We should merge ASAP if good. |
Contributor
|
@wmertens can you please take a look if all good when you have a minute? (thanks 🙏 ) |
wmertens
approved these changes
Jun 14, 2025
wmertens
left a comment
wmertens
left a comment
Member
There was a problem hiding this comment.
I'm not sure I quite understand how this works but LGTM
github-project-automation
Bot
moved this from Waiting For Review
to Done
in Qwik Development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description
an http source request will be blocked by middleware in Qwikcore when project is the library mode.
this is because library mode's
pluginfunction inconfigureServerwill be executed immediately, in contrast, in a normal project that has a router Vite plugin will be deferred.#7600
Checklist
pnpm change