fix(vscode): force fresh ACP session on new-session action#2874
Open
yiliang114 wants to merge 2 commits intomainfrom
Open
fix(vscode): force fresh ACP session on new-session action#2874yiliang114 wants to merge 2 commits intomainfrom
yiliang114 wants to merge 2 commits intomainfrom
Conversation
Ensure explicit new-session actions bypass active ACP session reuse so the VS Code sidebar clears context correctly. Add regression coverage for the agent manager and webview new-session entry points.
Replace the runtime import of `isSupportedImageMimeType` from `@qwen-code/qwen-code-core` with a local `SUPPORTED_PASTED_IMAGE_MIME_TYPES` set in the vscode-ide-companion package. The webview is bundled for a browser environment where Node.js-only core modules are unavailable, so keeping the MIME list local avoids esbuild failures during development. Added tests to verify the local list stays aligned with core and that the webview bundle does not contain core runtime imports.
yiliang114
requested review from
DennisYu07,
DragonnZhang,
LaZzyMan,
Mingholy,
gwinthis,
pomelo-nwu and
tanzhenxin
as code owners
4 tasks
Contributor
📋 Review SummaryThis PR addresses issue #2847 by fixing a bug where clicking the "+" (new session) button in the VSCode sidebar silently reused the existing ACP session instead of creating a fresh one. The fix introduces a 🔍 General Feedback
🎯 Specific Feedback🟡 High
🟢 Medium
🔵 Low
✅ Highlights
|
yiliang114
changed the title
Contributor
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createNewSession()silently reused the existing ACP session when one was already active, so clicking the "+" (new session) button in the sidebar had no effect — context, model info, and usage stats were never reset.forceNewoption toAgentSessionOptionsand pass{ forceNew: true }from all explicit new-session call sites (SessionMessageHandler,WebViewProvider). The implicit bootstrap path continues to reuse existing sessions as before.isSupportedImageMimeTypefrom@qwen-code/qwen-code-coreinimageSupport.ts— the webview is bundled for a browser environment where Node.js-only core modules cause esbuild failures during development. Replaced with a localSUPPORTED_PASTED_IMAGE_MIME_TYPESset, with a test that pins it to the core-supported list.Files changed
qwenAgentManager.tsforceNewoption, bypass session reuse when setSessionMessageHandler.ts{ forceNew: true }for explicit new-session actionsWebViewProvider.ts{ forceNew: true }for sidebar new-session buttonimageSupport.tsforceNewbehavior and bundle safetyTest plan
qwenAgentManager.test.ts— verifiesforceNew: truecreates a fresh session even when one existsSessionMessageHandler.test.ts— verifies new-session webview message passesforceNewWebViewProvider.test.ts— verifies sidebar action passesforceNewimageSupport.test.ts— verifies local MIME set stays aligned with coreimageSupport.bundle.test.ts— verifies webview bundle has no core runtime importsCloses #2847