Fix label alignment bug in finetuning#278
Open
matevosashot wants to merge 1 commit intoQwenLM:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix label alignment bug in finetuning
Fixes label alignment issues in
sft_12hz.pyandmodeling_qwen3_tts.pycaused by incorrect interaction withForCausalLMLossfromtransformers.Context
ForCausalLMLosshas two modes: passinglabelsautomatically shifts them left by one (token n predicts n+1), while passingshift_labelsuses them as-is.sft_12hz.pyThe old code manually shifted inputs and labels before passing to the talker (
inputs_embeds[:, :-1],labels[:, 1:]). This is unnecessary —ForCausalLMLossalready handles the left-shift internally. The fix passes full unshifted tensors and adjusts hidden state slicing accordingly. Also adds the missingtext_projectioncall on text embeddings.modeling_qwen3_tts.pyThe subtalker outputs 15 codes per position. Passing them via
labelscausesForCausalLMLossto shift and drop one, leaving only 14 — misaligning with the 15 logit outputs. The fix passes subtalker labels viashift_labelsinstead, bypassing the automatic shift.ForCausalLMLoss implementation: