Fix thread-unsafe singleton pattern in MCPManager#832
Open
Jah-yee wants to merge 2 commits intoQwenLM:mainfrom
Open
Fix thread-unsafe singleton pattern in MCPManager#832Jah-yee wants to merge 2 commits intoQwenLM:mainfrom
Jah-yee wants to merge 2 commits intoQwenLM:mainfrom
Conversation
The example code incorrectly uses request.get() instead of requests.get(). This is a simple documentation fix to ensure accuracy.
Add thread-safe singleton using double-checked locking pattern. This prevents race conditions when multiple threads try to create the MCPManager instance simultaneously (e.g., in Gradio WebUI or ASGI server environments). Fixes: QwenLM#812
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #812
Add thread-safe singleton using double-checked locking pattern. This prevents race conditions when multiple threads try to create the MCPManager instance simultaneously.