fix: thread-safe singleton pattern in MCPManager#822
Open
Jah-yee wants to merge 1 commit intoQwenLM:mainfrom
Open
fix: thread-safe singleton pattern in MCPManager#822Jah-yee wants to merge 1 commit intoQwenLM:mainfrom
Jah-yee wants to merge 1 commit intoQwenLM:mainfrom
Conversation
- Add threading.Lock to prevent race condition in singleton creation - Multiple threads can now safely initialize MCPManager concurrently - Fixes issue QwenLM#812
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue #812 - Thread unsafe singleton pattern in MCPManager
The MCPManager class uses a singleton pattern that is not thread-safe. In a multi-threaded environment, two threads can simultaneously evaluate
cls._instance is Noneas True, resulting in multiple instances being created.Solution
Added
threading.Lock()to ensure thread-safe singleton creation:This prevents race conditions when multiple threads try to initialize MCPManager concurrently (e.g., when serving multiple users via Gradio WebUI or ASGI servers).
Testing
The fix ensures that only one instance of MCPManager is created even when accessed concurrently from multiple threads.