fix: request.get -> requests.get + thread-safe MCPManager#818
Open
Jah-yee wants to merge 3 commits intoQwenLM:mainfrom
Open
fix: request.get -> requests.get + thread-safe MCPManager#818Jah-yee wants to merge 3 commits intoQwenLM:mainfrom
Jah-yee wants to merge 3 commits intoQwenLM:mainfrom
Conversation
The code example incorrectly uses request.get instead of requests.get. This fixes issue QwenLM#825.
The issue QwenLM#825 mentions that request.get should be requests.get for accuracy, as the requests library is the standard way to make HTTP requests in Python.
Jah-yee
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix 1: Issue #825 - request.get -> requests.get
The issue #825 mentions that
request.getshould berequests.getfor accuracy, as the requests library is the standard way to make HTTP requests in Python.Fixed in:
qwen_agent/llm/openvino.pyqwen-agent-docs/website/content/en/guide/get_started/quickstart.mdFix 2: MCPManager thread safety
The MCPManager class in
qwen_agent/tools/mcp_manager.pyuses a singleton pattern that is not thread-safe. Added a class-level threading lock to ensure atomic instance creation.Testing
Both are documentation and code quality fixes - no functional changes to the core logic.