Skip to content

Hide freeplaced entities inside secured ConstructionChildEntities #2443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

Nikolassparrow
Copy link
Collaborator

https://streamable.com/4245k3 (sorry about music)

Currently freeplaced entities are visible to players outside of secured shelters/shacks. Players are hidden which is great, but most, if not all entities inside of a secured shelter/shack should be hidden. Work is still needed on #1665 for adding a "securedShelter" variable, but using existing isHidden architecture, can still accomplish our goals.

Ideally this should be tested on DeadZone, or another private server to insure there are no strange bugs or exploits tied in. From testing, it felt stable minus a small drawback in time - that should be looked into so it doesn't cause unnecessary lag on the server.

@github-actions github-actions bot added the client-2016 About the 2016 client label Feb 6, 2025
@QuentinGruber
Copy link
Owner

from what i saw it doesn't seems to affect performances. we will test that during the next week

);
}

const isSameGroup =
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why does it has to be in the same group ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's also in constructionHidePlayer. From testing on my own, it's so players can still see their teammates if they're inside a specific shelter/part of base. This would be useful if you lived in a big base and your teammate asks: "hey come to me" you can know where is at.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's also in constructionHidePlayer. From testing on my own, it's so players can still see their teammates if they're inside a specific shelter/part of base. This would be useful if you lived in a big base and your teammate asks: "hey come to me" you can know where is at.

@QuentinGruber maybe give the man an reply ppl want to have this ingame

https://discord.com/channels/707525351357677610/1361406050099662958

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's also in constructionHidePlayer. From testing on my own, it's so players can still see their teammates if they're inside a specific shelter/part of base. This would be useful if you lived in a big base and your teammate asks: "hey come to me" you can know where is at.

@QuentinGruber maybe give the man an reply ppl want to have this ingame

https://discord.com/channels/707525351357677610/1361406050099662958

i just need to test this before rolling it out

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hows it going on this one, can we push it to test server?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hows it going on this one, can we push it to test server?

done

@QuentinGruber QuentinGruber added this to the 0.46.0 milestone Apr 16, 2025
@QuentinGruber QuentinGruber moved this to In Review in H1emu Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client-2016 About the 2016 client
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

4 participants