Skip to content

Conversation

@alimirjamali
Copy link
Contributor

Provide user a selection of default compression filters in addition to the available recognised filters. Allow user to save the filter.

Requires: QubesOS/qubes-core-admin-client#346

Related: QubesOS/qubes-issues#8211
Related: QubesOS/qubes-issues#8291

@codecov
Copy link

codecov bot commented Apr 16, 2025

Codecov Report

Attention: Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.07%. Comparing base (6d7ac61) to head (d90b48c).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
qubesmanager/backup.py 95.23% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #420      +/-   ##
==========================================
+ Coverage   68.89%   69.07%   +0.18%     
==========================================
  Files          17       17              
  Lines        3838     3858      +20     
==========================================
+ Hits         2644     2665      +21     
+ Misses       1194     1193       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@qubesos-bot
Copy link

qubesos-bot commented Apr 25, 2025

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025050820-4.3&flavor=pull-requests

Test run included the following:

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025031804-4.3&flavor=update

  • system_tests_suspend

    • suspend: wait_serial (wait serial expected)
      # wait_serial expected: qr/wG5VX-\d+-/...
  • system_tests_basic_vm_qrexec_gui

    • TC_20_NonAudio_whonix-gateway-17: test_000_start_shutdown (error + cleanup)
      raise TimeoutError from exc_val... TimeoutError
  • system_tests_extra

    • TC_00_InputProxy_debian-12-xfce: test_000_simple_mouse (failure)
      AssertionError: unexpectedly None : Device 'test-inst-input: Test i...

    • TC_00_InputProxy_debian-12-xfce: test_010_mouse_deny_keyboard (failure)
      AssertionError: unexpectedly None : Device 'test-inst-input: Test i...

    • TC_00_InputProxy_debian-12-xfce: test_020_mouse_keyboard_mouse_only (failure)
      AssertionError: unexpectedly None : Device 'test-inst-input: Test i...

    • TC_00_InputProxy_debian-12-xfce: test_030_simple_keyboard (failure)
      AssertionError: unexpectedly None : Device 'test-inst-input: Test i...

    • TC_00_InputProxy_debian-12-xfce: test_040_mouse_keyboard (failure)
      AssertionError: unexpectedly None : Device 'pointer:test-inst-input...

    • TC_00_InputProxy_debian-12-xfce: test_050_mouse_late_attach (failure)
      AssertionError: unexpectedly None : Device 'test-inst-input: Test i...

    • TC_00_InputProxy_fedora-41-xfce: test_000_simple_mouse (failure)
      AssertionError: unexpectedly None : Device 'test-inst-input: Test i...

    • TC_00_InputProxy_fedora-41-xfce: test_010_mouse_deny_keyboard (failure)
      AssertionError: unexpectedly None : Device 'test-inst-input: Test i...

    • TC_00_InputProxy_fedora-41-xfce: test_020_mouse_keyboard_mouse_only (failure)
      AssertionError: unexpectedly None : Device 'test-inst-input: Test i...

    • TC_00_InputProxy_fedora-41-xfce: test_030_simple_keyboard (failure)
      AssertionError: unexpectedly None : Device 'test-inst-input: Test i...

    • TC_00_InputProxy_fedora-41-xfce: test_040_mouse_keyboard (failure)
      AssertionError: unexpectedly None : Device 'pointer:test-inst-input...

    • TC_00_InputProxy_fedora-41-xfce: test_050_mouse_late_attach (failure)
      AssertionError: unexpectedly None : Device 'test-inst-input: Test i...

  • system_tests_guivm_gui_interactive

    • clipboard_and_web: unnamed test (unknown)
    • clipboard_and_web: Failed (test died)
      # Test died: no candidate needle with tag(s) 'clipboard-paste-notif...
  • system_tests_devices

    • TC_00_List_whonix-gateway-17: test_011_list_dm_mounted (failure)
      AssertionError: 'test-dm' == 'test-dm' : Device test-inst-vm:dm-0::...
  • system_tests_kde_gui_interactive

    • gui_keyboard_layout: wait_serial (wait serial expected)
      # wait_serial expected: "echo -e '[Layout]\nLayoutList=us,de' | sud...

    • gui_keyboard_layout: Failed (test died)
      # Test died: command 'test "$(cd ~user;ls e1*)" = "$(qvm-run -p wor...

  • system_tests_basic_vm_qrexec_gui_zfs

    • TC_20_NonAudio_whonix-workstation-17-pool: test_012_qubes_desktop_run (error + cleanup)
      raise TimeoutError from exc_val... TimeoutError
  • system_tests_guivm_vnc_gui_interactive

    • clipboard_and_web: unnamed test (unknown)
    • clipboard_and_web: Failed (test died)
      # Test died: no candidate needle with tag(s) 'clipboard-copy-notifi...
  • system_tests_qwt_win10_seamless@hw13

    • windows_clipboard_and_filecopy: unnamed test (unknown)
    • windows_clipboard_and_filecopy: Failed (test died)
      # Test died: no candidate needle with tag(s) 'windows-Edge-no-profi...
  • system_tests_qwt_win11@hw13

    • windows_clipboard_and_filecopy: unnamed test (unknown)
    • windows_clipboard_and_filecopy: Failed (test died)
      # Test died: no candidate needle with tag(s) 'windows-Explorer-new-...
  • system_tests_guivm_gpu_gui_interactive@hw13

    • guivm_startup: unnamed test (unknown)
    • guivm_startup: Failed (test died)
      # Test died: no candidate needle with tag(s) 'desktop' matched...

Failed tests

29 failures
  • system_tests_suspend

    • suspend: wait_serial (wait serial expected)
      # wait_serial expected: qr/wG5VX-\d+-/...

    • suspend: Failed (test died + timed out)
      # Test died: command 'qvm-run -ap sys-whonix 'LC_ALL=C whonixcheck ...

  • system_tests_basic_vm_qrexec_gui

    • TC_20_NonAudio_whonix-gateway-17: test_000_start_shutdown (error + cleanup)
      raise TimeoutError from exc_val... TimeoutError
  • system_tests_extra

    • TC_00_InputProxy_debian-12-xfce: test_000_simple_mouse (failure)
      AssertionError: unexpectedly None : Device 'test-inst-input: Test i...

    • TC_00_InputProxy_debian-12-xfce: test_010_mouse_deny_keyboard (failure)
      AssertionError: unexpectedly None : Device 'test-inst-input: Test i...

    • TC_00_InputProxy_debian-12-xfce: test_020_mouse_keyboard_mouse_only (failure)
      AssertionError: unexpectedly None : Device 'test-inst-input: Test i...

    • TC_00_InputProxy_debian-12-xfce: test_030_simple_keyboard (failure)
      AssertionError: unexpectedly None : Device 'test-inst-input: Test i...

    • TC_00_InputProxy_debian-12-xfce: test_040_mouse_keyboard (failure)
      AssertionError: unexpectedly None : Device 'pointer:test-inst-input...

    • TC_00_InputProxy_debian-12-xfce: test_050_mouse_late_attach (failure)
      AssertionError: unexpectedly None : Device 'test-inst-input: Test i...

    • TC_00_InputProxy_fedora-41-xfce: test_000_simple_mouse (failure)
      AssertionError: unexpectedly None : Device 'test-inst-input: Test i...

    • TC_00_InputProxy_fedora-41-xfce: test_010_mouse_deny_keyboard (failure)
      AssertionError: unexpectedly None : Device 'test-inst-input: Test i...

    • TC_00_InputProxy_fedora-41-xfce: test_020_mouse_keyboard_mouse_only (failure)
      AssertionError: unexpectedly None : Device 'test-inst-input: Test i...

    • TC_00_InputProxy_fedora-41-xfce: test_030_simple_keyboard (failure)
      AssertionError: unexpectedly None : Device 'test-inst-input: Test i...

    • TC_00_InputProxy_fedora-41-xfce: test_040_mouse_keyboard (failure)
      AssertionError: unexpectedly None : Device 'pointer:test-inst-input...

    • TC_00_InputProxy_fedora-41-xfce: test_050_mouse_late_attach (failure)
      AssertionError: unexpectedly None : Device 'test-inst-input: Test i...

  • system_tests_guivm_gui_interactive

    • clipboard_and_web: unnamed test (unknown)
    • clipboard_and_web: Failed (test died)
      # Test died: no candidate needle with tag(s) 'clipboard-paste-notif...
  • system_tests_devices

    • TC_00_List_whonix-gateway-17: test_011_list_dm_mounted (failure)
      AssertionError: 'test-dm' == 'test-dm' : Device test-inst-vm:dm-0::...
  • system_tests_kde_gui_interactive

    • gui_keyboard_layout: wait_serial (wait serial expected)
      # wait_serial expected: "echo -e '[Layout]\nLayoutList=us,de' | sud...

    • gui_keyboard_layout: Failed (test died)
      # Test died: command 'test "$(cd ~user;ls e1*)" = "$(qvm-run -p wor...

  • system_tests_basic_vm_qrexec_gui_zfs

    • TC_20_NonAudio_whonix-workstation-17-pool: test_012_qubes_desktop_run (error + cleanup)
      raise TimeoutError from exc_val... TimeoutError
  • system_tests_guivm_vnc_gui_interactive

    • clipboard_and_web: unnamed test (unknown)
    • clipboard_and_web: Failed (test died)
      # Test died: no candidate needle with tag(s) 'clipboard-copy-notifi...
  • system_tests_qwt_win10_seamless@hw13

    • windows_clipboard_and_filecopy: unnamed test (unknown)
    • windows_clipboard_and_filecopy: Failed (test died)
      # Test died: no candidate needle with tag(s) 'windows-Edge-no-profi...
  • system_tests_qwt_win11@hw13

    • windows_clipboard_and_filecopy: unnamed test (unknown)
    • windows_clipboard_and_filecopy: Failed (test died)
      # Test died: no candidate needle with tag(s) 'windows-Explorer-new-...
  • system_tests_guivm_gpu_gui_interactive@hw13

    • guivm_startup: unnamed test (unknown)
    • guivm_startup: Failed (test died)
      # Test died: no candidate needle with tag(s) 'desktop' matched...

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/132953#dependencies

13 fixed
  • system_tests_suspend

  • system_tests_basic_vm_qrexec_gui

  • system_tests_kde_gui_interactive

    • clipboard_and_web: unnamed test (unknown)

    • clipboard_and_web: Failed (test died)
      # Test died: no candidate needle with tag(s) 'qubes-website' matche...

    • clipboard_and_web: wait_serial (wait serial expected)
      # wait_serial expected: "lspci; echo 2E8vz-\$?-"...

  • system_tests_guivm_vnc_gui_interactive

    • gui_filecopy: unnamed test (unknown)
    • gui_filecopy: Failed (test died)
      # Test died: no candidate needle with tag(s) 'files-work' matched...
  • system_tests_audio

  • system_tests_whonix@hw7

    • whonixcheck: fail (unknown)
      Whonixcheck for sys-whonix failed...

    • whonixcheck: unnamed test (unknown)

  • system_tests_qrexec

  • system_tests_whonix

    • whonixcheck: fail (unknown)
      Whonixcheck for sys-whonix failed...

    • whonixcheck: unnamed test (unknown)

Unstable tests

Performance Tests

Performance degradation:

20 performance degradations
  • debian-12-xfce_exec-data-duplex-root: 93.70 :small_red_triangle_up: ( previous job: 82.72, degradation: 113.28%)
  • whonix-gateway-17_socket: 9.42 :small_red_triangle_up: ( previous job: 7.24, degradation: 130.21%)
  • dom0_root_seq1m_q8t1_write 3:write_bandwidth_kb: 83934.00 :small_red_triangle_up: ( previous job: 129298.00, degradation: 64.92%)
  • dom0_root_seq1m_q1t1_read 3:read_bandwidth_kb: 85975.00 :small_red_triangle_up: ( previous job: 294295.00, degradation: 29.21%)
  • dom0_root_seq1m_q1t1_write 3:write_bandwidth_kb: 20787.00 :small_red_triangle_up: ( previous job: 95454.00, degradation: 21.78%)
  • dom0_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 20898.00 :small_red_triangle_up: ( previous job: 79803.00, degradation: 26.19%)
  • dom0_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 4628.00 :small_red_triangle_up: ( previous job: 6149.00, degradation: 75.26%)
  • dom0_varlibqubes_seq1m_q8t1_write 3:write_bandwidth_kb: 93974.00 :small_red_triangle_up: ( previous job: 250795.00, degradation: 37.47%)
  • dom0_varlibqubes_seq1m_q1t1_write 3:write_bandwidth_kb: 164640.00 :small_red_triangle_up: ( previous job: 184752.00, degradation: 89.11%)
  • dom0_varlibqubes_rnd4k_q32t1_write 3:write_bandwidth_kb: 4662.00 :small_red_triangle_up: ( previous job: 6479.00, degradation: 71.96%)
  • dom0_varlibqubes_rnd4k_q1t1_write 3:write_bandwidth_kb: 4092.00 :small_red_triangle_up: ( previous job: 4903.00, degradation: 83.46%)
  • fedora-41-xfce_root_seq1m_q1t1_write 3:write_bandwidth_kb: 60908.00 :small_red_triangle_up: ( previous job: 87940.00, degradation: 69.26%)
  • fedora-41-xfce_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 2003.00 :small_red_triangle_up: ( previous job: 3599.00, degradation: 55.65%)
  • fedora-41-xfce_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 7163.00 :small_red_triangle_up: ( previous job: 8485.00, degradation: 84.42%)
  • fedora-41-xfce_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 449.00 :small_red_triangle_up: ( previous job: 542.00, degradation: 82.84%)
  • fedora-41-xfce_private_seq1m_q8t1_write 3:write_bandwidth_kb: 127388.00 :small_red_triangle_up: ( previous job: 170062.00, degradation: 74.91%)
  • fedora-41-xfce_private_seq1m_q1t1_write 3:write_bandwidth_kb: 45170.00 :small_red_triangle_up: ( previous job: 61534.00, degradation: 73.41%)
  • fedora-41-xfce_volatile_seq1m_q8t1_read 3:read_bandwidth_kb: 300107.00 :small_red_triangle_up: ( previous job: 369868.00, degradation: 81.14%)
  • fedora-41-xfce_volatile_seq1m_q8t1_write 3:write_bandwidth_kb: 160679.00 :small_red_triangle_up: ( previous job: 179949.00, degradation: 89.29%)
  • fedora-41-xfce_volatile_rnd4k_q32t1_write 3:write_bandwidth_kb: 2800.00 :small_red_triangle_up: ( previous job: 5672.00, degradation: 49.37%)

Remaining performance tests:

52 tests
  • debian-12-xfce_exec: 6.35 🟢 ( previous job: 7.12, improvement: 89.24%)
  • debian-12-xfce_exec-root: 29.36 :small_red_triangle_up: ( previous job: 28.65, degradation: 102.46%)
  • debian-12-xfce_socket: 7.83 🟢 ( previous job: 8.60, improvement: 91.07%)
  • debian-12-xfce_socket-root: 8.94 :small_red_triangle_up: ( previous job: 8.52, degradation: 104.86%)
  • debian-12-xfce_exec-data-simplex: 72.51 :small_red_triangle_up: ( previous job: 71.62, degradation: 101.23%)
  • debian-12-xfce_exec-data-duplex: 69.55 🟢 ( previous job: 70.34, improvement: 98.88%)
  • debian-12-xfce_socket-data-duplex: 166.06 :small_red_triangle_up: ( previous job: 156.96, degradation: 105.80%)
  • fedora-41-xfce_exec: 9.18 🟢 ( previous job: 9.27, improvement: 99.11%)
  • fedora-41-xfce_exec-root: 59.86 🟢 ( previous job: 61.51, improvement: 97.33%)
  • fedora-41-xfce_socket: 8.26 🟢 ( previous job: 8.63, improvement: 95.71%)
  • fedora-41-xfce_socket-root: 8.45 🟢 ( previous job: 8.71, improvement: 97.09%)
  • fedora-41-xfce_exec-data-simplex: 67.60 🟢 ( previous job: 75.53, improvement: 89.50%)
  • fedora-41-xfce_exec-data-duplex: 68.80 🟢 ( previous job: 71.56, improvement: 96.15%)
  • fedora-41-xfce_exec-data-duplex-root: 92.11 🟢 ( previous job: 109.13, improvement: 84.41%)
  • fedora-41-xfce_socket-data-duplex: 133.49 🟢 ( previous job: 150.61, improvement: 88.64%)
  • whonix-gateway-17_exec: 6.16 🟢 ( previous job: 6.82, improvement: 90.31%)
  • whonix-gateway-17_exec-root: 40.25 🟢 ( previous job: 40.43, improvement: 99.54%)
  • whonix-gateway-17_socket-root: 7.69 :small_red_triangle_up: ( previous job: 7.65, degradation: 100.48%)
  • whonix-gateway-17_exec-data-simplex: 77.03 🟢 ( previous job: 78.32, improvement: 98.35%)
  • whonix-gateway-17_exec-data-duplex: 80.76 :small_red_triangle_up: ( previous job: 76.65, degradation: 105.36%)
  • whonix-gateway-17_exec-data-duplex-root: 80.93 🟢 ( previous job: 88.52, improvement: 91.42%)
  • whonix-gateway-17_socket-data-duplex: 169.54 🟢 ( previous job: 171.76, improvement: 98.71%)
  • whonix-workstation-17_exec: 8.23 :small_red_triangle_up: ( previous job: 7.67, degradation: 107.24%)
  • whonix-workstation-17_exec-root: 54.57 🟢 ( previous job: 58.26, improvement: 93.66%)
  • whonix-workstation-17_socket: 7.81 🟢 ( previous job: 8.19, improvement: 95.26%)
  • whonix-workstation-17_socket-root: 8.18 :small_red_triangle_up: ( previous job: 8.13, degradation: 100.68%)
  • whonix-workstation-17_exec-data-simplex: 77.07 :small_red_triangle_up: ( previous job: 74.99, degradation: 102.77%)
  • whonix-workstation-17_exec-data-duplex: 77.63 :small_red_triangle_up: ( previous job: 72.71, degradation: 106.76%)
  • whonix-workstation-17_exec-data-duplex-root: 91.96 🟢 ( previous job: 99.82, improvement: 92.13%)
  • whonix-workstation-17_socket-data-duplex: 165.30 🟢 ( previous job: 169.50, improvement: 97.52%)
  • dom0_root_seq1m_q8t1_read 3:read_bandwidth_kb: 431157.00 :small_red_triangle_up: ( previous job: 446963.00, degradation: 96.46%)
  • dom0_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 9833.00 :small_red_triangle_up: ( previous job: 10795.00, degradation: 91.09%)
  • dom0_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 4473.00 :small_red_triangle_up: ( previous job: 4826.00, degradation: 92.69%)
  • dom0_varlibqubes_seq1m_q8t1_read 3:read_bandwidth_kb: 468532.00 :green_circle: ( previous job: 382273.00, improvement: 122.56%)
  • dom0_varlibqubes_seq1m_q1t1_read 3:read_bandwidth_kb: 410080.00 :small_red_triangle_up: ( previous job: 437636.00, degradation: 93.70%)
  • dom0_varlibqubes_rnd4k_q32t1_read 3:read_bandwidth_kb: 102529.00 :green_circle: ( previous job: 62195.00, improvement: 164.85%)
  • dom0_varlibqubes_rnd4k_q1t1_read 3:read_bandwidth_kb: 8924.00 :green_circle: ( previous job: 7669.00, improvement: 116.36%)
  • fedora-41-xfce_root_seq1m_q8t1_read 3:read_bandwidth_kb: 396287.00 :green_circle: ( previous job: 368309.00, improvement: 107.60%)
  • fedora-41-xfce_root_seq1m_q8t1_write 3:write_bandwidth_kb: 157353.00 :small_red_triangle_up: ( previous job: 162081.00, degradation: 97.08%)
  • fedora-41-xfce_root_seq1m_q1t1_read 3:read_bandwidth_kb: 308858.00 :small_red_triangle_up: ( previous job: 318716.00, degradation: 96.91%)
  • fedora-41-xfce_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 89779.00 :green_circle: ( previous job: 82694.00, improvement: 108.57%)
  • fedora-41-xfce_private_seq1m_q8t1_read 3:read_bandwidth_kb: 352818.00 :small_red_triangle_up: ( previous job: 373957.00, degradation: 94.35%)
  • fedora-41-xfce_private_seq1m_q1t1_read 3:read_bandwidth_kb: 363710.00 :green_circle: ( previous job: 334687.00, improvement: 108.67%)
  • fedora-41-xfce_private_rnd4k_q32t1_read 3:read_bandwidth_kb: 90376.00 :green_circle: ( previous job: 80283.00, improvement: 112.57%)
  • fedora-41-xfce_private_rnd4k_q32t1_write 3:write_bandwidth_kb: 2196.00 :small_red_triangle_up: ( previous job: 2215.00, degradation: 99.14%)
  • fedora-41-xfce_private_rnd4k_q1t1_read 3:read_bandwidth_kb: 8351.00 :green_circle: ( previous job: 7540.00, improvement: 110.76%)
  • fedora-41-xfce_private_rnd4k_q1t1_write 3:write_bandwidth_kb: 1381.00 :green_circle: ( previous job: 1130.00, improvement: 122.21%)
  • fedora-41-xfce_volatile_seq1m_q1t1_read 3:read_bandwidth_kb: 314038.00 :small_red_triangle_up: ( previous job: 324737.00, degradation: 96.71%)
  • fedora-41-xfce_volatile_seq1m_q1t1_write 3:write_bandwidth_kb: 72705.00 :green_circle: ( previous job: 17567.00, improvement: 413.87%)
  • fedora-41-xfce_volatile_rnd4k_q32t1_read 3:read_bandwidth_kb: 86036.00 :green_circle: ( previous job: 79021.00, improvement: 108.88%)
  • fedora-41-xfce_volatile_rnd4k_q1t1_read 3:read_bandwidth_kb: 8263.00 :green_circle: ( previous job: 7867.00, improvement: 105.03%)
  • fedora-41-xfce_volatile_rnd4k_q1t1_write 3:write_bandwidth_kb: 1887.00 :small_red_triangle_up: ( previous job: 1953.00, degradation: 96.62%)

@marmarek
Copy link
Member

This doesn't work: https://openqa.qubes-os.org/tests/137193#step/qubesmanager_backuprestore/9
There is no default selected, and the list appears to be empty.

@alimirjamali
Copy link
Contributor Author

This doesn't work: https://openqa.qubes-os.org/tests/137193#step/qubesmanager_backuprestore/9 There is no default selected, and the list appears to be empty.

I am trying to figure out what is wrong here. It appears that the UI file is applied but the code is not.

Provide user a selection of default compression filters in addition to
the available recognised filters. Allow user to save the filter.

Requires: QubesOS/qubes-core-admin-client#346

Related: QubesOS/qubes-issues#8211
Related: QubesOS/qubes-issues#8291
@marmarek marmarek merged commit 6ffc615 into QubesOS:main May 9, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants