tests: add an integration test for no-revisions volume #691

marmarek · 2025-06-29T02:31:42Z

codecov · 2025-06-29T02:45:50Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.44%. Comparing base (bc20def) to head (40763a4).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #691      +/-   ##
==========================================
- Coverage   70.59%   70.44%   -0.15%     
==========================================
  Files          61       61              
  Lines       13306    13305       -1     
==========================================
- Hits         9393     9373      -20     
- Misses       3913     3932      +19

Flag	Coverage Δ
unittests	`70.44% <ø> (-0.15%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

rustybird · 2025-06-29T17:21:02Z

qubes/tests/integ/storage.py

        self.assertEqual(testvol2.size, size)

+    def test_006_no_revisions(self):
+        """Test if non-volatile volume is really non-volatile"""


qubesos-bot · 2025-07-03T22:03:03Z

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025070405-4.3&flavor=pull-requests

Test run included the following:

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025061004-4.3&flavor=update

system_tests_pvgrub_salt_storage
- StorageFile: test_006_no_revisions (error)
  RuntimeError: This event loop is already running
- StorageLVM: test_006_no_revisions (error)
  RuntimeError: This event loop is already running
- StorageReflinkOnBtrfs: test_006_no_revisions (error)
  RuntimeError: This event loop is already running
- StorageReflinkOnExt4: test_006_no_revisions (error)
  RuntimeError: This event loop is already running
system_tests_kde_gui_interactive
- kde_install: wait_serial (wait serial expected)
  # wait_serial expected: qr/1YA~i-\d+-/...
- kde_install: Failed (test died + timed out)
  # Test died: command '(set -o pipefail; sudo qubes-dom0-update -y k...
system_tests_guivm_vnc_gui_interactive
- guivm_startup: unnamed test (unknown)
- guivm_startup: Failed (test died)
  # Test died: no candidate needle with tag(s) 'desktop' matched...
system_tests_qwt_win10_seamless@hw13
- windows_clipboard_and_filecopy: unnamed test (unknown)
- windows_clipboard_and_filecopy: Failed (test died)
  # Test died: no candidate needle with tag(s) 'windows-Edge-address-...
system_tests_qwt_win11@hw13
- windows_install: wait_serial (wait serial expected)
  # wait_serial expected: qr/dcWzE-\d+-/...
- windows_install: Failed (test died + timed out)
  # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...
system_tests_basic_vm_qrexec_gui_xfs
- TC_20_NonAudio_whonix-gateway-17-pool: test_012_qubes_desktop_run (error)
  subprocess.CalledProcessError: Command 'qubes.WaitForSession' retur...

Failed tests

15 failures

system_tests_pvgrub_salt_storage
- StorageFile: test_006_no_revisions (error)
  RuntimeError: This event loop is already running
- StorageLVM: test_006_no_revisions (error)
  RuntimeError: This event loop is already running
- StorageReflinkOnBtrfs: test_006_no_revisions (error)
  RuntimeError: This event loop is already running
- StorageReflinkOnExt4: test_006_no_revisions (error)
  RuntimeError: This event loop is already running
system_tests_splitgpg
- TC_10_Thunderbird_whonix-workstation-17: test_010_send_receive_inline_signed_only (failure)
  dogtail.tree.SearchError: descendent of [panel | ]: child with name...
system_tests_extra
- TC_00_QVCTest_whonix-workstation-17: test_010_screenshare (failure)
  AssertionError: 1 != 0 : Timeout waiting for /dev/video0 in test-in...
system_tests_kde_gui_interactive
- kde_install: wait_serial (wait serial expected)
  # wait_serial expected: qr/1YA~i-\d+-/...
- kde_install: Failed (test died + timed out)
  # Test died: command '(set -o pipefail; sudo qubes-dom0-update -y k...
system_tests_guivm_vnc_gui_interactive
- guivm_startup: unnamed test (unknown)
- guivm_startup: Failed (test died)
  # Test died: no candidate needle with tag(s) 'desktop' matched...
system_tests_qwt_win10_seamless@hw13
- windows_clipboard_and_filecopy: unnamed test (unknown)
- windows_clipboard_and_filecopy: Failed (test died)
  # Test died: no candidate needle with tag(s) 'windows-Edge-address-...
system_tests_qwt_win11@hw13
- windows_install: wait_serial (wait serial expected)
  # wait_serial expected: qr/dcWzE-\d+-/...
- windows_install: Failed (test died + timed out)
  # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...
system_tests_basic_vm_qrexec_gui_xfs
- TC_20_NonAudio_whonix-gateway-17-pool: test_012_qubes_desktop_run (error)
  subprocess.CalledProcessError: Command 'qubes.WaitForSession' retur...

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/142375#dependencies

11 fixed

system_tests_splitgpg
- TC_10_Thunderbird_whonix-workstation-17: test_000_send_receive_default (failure)
  dogtail.tree.SearchError: descendent of [application | Thunderbird]...
- TC_10_Thunderbird_whonix-workstation-17: test_020_send_receive_inline_with_attachment (failure)
  dogtail.tree.SearchError: descendent of [application | Thunderbird]...
system_tests_extra
- TC_10_Thunderbird_whonix-workstation-17: test_000_send_receive_default (failure)
  dogtail.tree.SearchError: descendent of [application | Thunderbird]...
- TC_10_Thunderbird_whonix-workstation-17: test_010_send_receive_inline_signed_only (failure)
  dogtail.tree.SearchError: descendent of [application | Thunderbird]...
- TC_10_Thunderbird_whonix-workstation-17: test_020_send_receive_inline_with_attachment (failure)
  dogtail.tree.SearchError: descendent of [application | Thunderbird]...
system_tests_kde_gui_interactive
- gui_keyboard_layout: wait_serial (wait serial expected)
  # wait_serial expected: "echo -e '[Layout]\nLayoutList=us,de' | sud...
- gui_keyboard_layout: Failed (test died)
  # Test died: command 'test "$(cd ~user;ls e1*)" = "$(qvm-run -p wor...
system_tests_guivm_vnc_gui_interactive
- simple_gui_apps: unnamed test (unknown)
- simple_gui_apps: Failed (test died)
  # Test died: no candidate needle with tag(s) 'vm-settings-applicati...
system_tests_audio
- TC_20_AudioVM_Pulse_debian-12-xfce: test_252_audio_playback_audiovm_switch_hvm (failure)
  AssertionError: only silence detected, no useful audio data
- TC_20_AudioVM_Pulse_whonix-workstation-17: test_225_audio_rec_unmuted_hvm (failure)
  AssertionError: too short audio, expected 10s, got 7.95233560090703...

Unstable tests

Performance Tests

Performance degradation:

5 performance degradations

debian-12-xfce_exec-data-duplex-root: 89.40 🔺 ( previous job: 70.01, degradation: 127.70%)
whonix-gateway-17_socket: 9.08 🔺 ( previous job: 7.85, degradation: 115.67%)
whonix-workstation-17_exec-data-duplex-root: 101.77 🔺 ( previous job: 86.00, degradation: 118.33%)
dom0_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 8613.00 :small_red_triangle: ( previous job: 11086.00, degradation: 77.69%)
dom0_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 675.00 :small_red_triangle: ( previous job: 1840.00, degradation: 36.68%)

Remaining performance tests:

67 tests

debian-12-xfce_exec: 8.04 🟢 ( previous job: 8.63, improvement: 93.15%)
debian-12-xfce_exec-root: 28.87 🟢 ( previous job: 29.44, improvement: 98.07%)
debian-12-xfce_socket: 8.84 🔺 ( previous job: 8.50, degradation: 103.99%)
debian-12-xfce_socket-root: 7.75 🟢 ( previous job: 8.31, improvement: 93.20%)
debian-12-xfce_exec-data-simplex: 69.47 🔺 ( previous job: 65.51, degradation: 106.04%)
debian-12-xfce_exec-data-duplex: 72.15 🟢 ( previous job: 73.55, improvement: 98.10%)
debian-12-xfce_socket-data-duplex: 163.46 🔺 ( previous job: 161.35, degradation: 101.31%)
fedora-42-xfce_exec: 9.06
fedora-42-xfce_exec-root: 58.04
fedora-42-xfce_socket: 8.13
fedora-42-xfce_socket-root: 8.35
fedora-42-xfce_exec-data-simplex: 66.32
fedora-42-xfce_exec-data-duplex: 74.35
fedora-42-xfce_exec-data-duplex-root: 110.92
fedora-42-xfce_socket-data-duplex: 148.60
whonix-gateway-17_exec: 7.91 🔺 ( previous job: 7.34, degradation: 107.78%)
whonix-gateway-17_exec-root: 42.06 🔺 ( previous job: 39.57, degradation: 106.28%)
whonix-gateway-17_socket-root: 8.01 🔺 ( previous job: 7.89, degradation: 101.48%)
whonix-gateway-17_exec-data-simplex: 77.58 🟢 ( previous job: 77.76, improvement: 99.76%)
whonix-gateway-17_exec-data-duplex: 77.39 🟢 ( previous job: 78.39, improvement: 98.73%)
whonix-gateway-17_exec-data-duplex-root: 99.31 🔺 ( previous job: 90.74, degradation: 109.45%)
whonix-gateway-17_socket-data-duplex: 168.37 🔺 ( previous job: 161.95, degradation: 103.97%)
whonix-workstation-17_exec: 7.96 🟢 ( previous job: 8.27, improvement: 96.19%)
whonix-workstation-17_exec-root: 56.28 🟢 ( previous job: 57.61, improvement: 97.70%)
whonix-workstation-17_socket: 9.47 🔺 ( previous job: 8.97, degradation: 105.61%)
whonix-workstation-17_socket-root: 8.27 🟢 ( previous job: 9.46, improvement: 87.46%)
whonix-workstation-17_exec-data-simplex: 65.28 🟢 ( previous job: 74.54, improvement: 87.58%)
whonix-workstation-17_exec-data-duplex: 77.86 🔺 ( previous job: 74.84, degradation: 104.04%)
whonix-workstation-17_socket-data-duplex: 159.67 🟢 ( previous job: 160.20, improvement: 99.67%)
dom0_root_seq1m_q8t1_read 3:read_bandwidth_kb: 475760.00 :green_circle: ( previous job: 289982.00, improvement: 164.07%)
dom0_root_seq1m_q8t1_write 3:write_bandwidth_kb: 215845.00 :green_circle: ( previous job: 101988.00, improvement: 211.64%)
dom0_root_seq1m_q1t1_read 3:read_bandwidth_kb: 96904.00 :green_circle: ( previous job: 14284.00, improvement: 678.41%)
dom0_root_seq1m_q1t1_write 3:write_bandwidth_kb: 45227.00 :green_circle: ( previous job: 32696.00, improvement: 138.33%)
dom0_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 21250.00 :green_circle: ( previous job: 17102.00, improvement: 124.25%)
dom0_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 3061.00 :green_circle: ( previous job: 1091.00, improvement: 280.57%)
dom0_varlibqubes_seq1m_q8t1_read 3:read_bandwidth_kb: 464177.00 :green_circle: ( previous job: 289182.00, improvement: 160.51%)
dom0_varlibqubes_seq1m_q8t1_write 3:write_bandwidth_kb: 117701.00 :small_red_triangle: ( previous job: 122848.00, degradation: 95.81%)
dom0_varlibqubes_seq1m_q1t1_read 3:read_bandwidth_kb: 438367.00 :green_circle: ( previous job: 433654.00, improvement: 101.09%)
dom0_varlibqubes_seq1m_q1t1_write 3:write_bandwidth_kb: 151628.00 :small_red_triangle: ( previous job: 167872.00, degradation: 90.32%)
dom0_varlibqubes_rnd4k_q32t1_read 3:read_bandwidth_kb: 103480.00 :small_red_triangle: ( previous job: 108760.00, degradation: 95.15%)
dom0_varlibqubes_rnd4k_q32t1_write 3:write_bandwidth_kb: 8902.00 :green_circle: ( previous job: 8874.00, improvement: 100.32%)
dom0_varlibqubes_rnd4k_q1t1_read 3:read_bandwidth_kb: 8277.00 :green_circle: ( previous job: 6356.00, improvement: 130.22%)
dom0_varlibqubes_rnd4k_q1t1_write 3:write_bandwidth_kb: 4528.00 :green_circle: ( previous job: 4420.00, improvement: 102.44%)
fedora-42-xfce_root_seq1m_q8t1_read 3:read_bandwidth_kb: 367019.00
fedora-42-xfce_root_seq1m_q8t1_write 3:write_bandwidth_kb: 298739.00
fedora-42-xfce_root_seq1m_q1t1_read 3:read_bandwidth_kb: 327475.00
fedora-42-xfce_root_seq1m_q1t1_write 3:write_bandwidth_kb: 122488.00
fedora-42-xfce_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 83504.00
fedora-42-xfce_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 4582.00
fedora-42-xfce_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 7771.00
fedora-42-xfce_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 1280.00
fedora-42-xfce_private_seq1m_q8t1_read 3:read_bandwidth_kb: 382134.00
fedora-42-xfce_private_seq1m_q8t1_write 3:write_bandwidth_kb: 255127.00
fedora-42-xfce_private_seq1m_q1t1_read 3:read_bandwidth_kb: 316981.00
fedora-42-xfce_private_seq1m_q1t1_write 3:write_bandwidth_kb: 62677.00
fedora-42-xfce_private_rnd4k_q32t1_read 3:read_bandwidth_kb: 44045.00
fedora-42-xfce_private_rnd4k_q32t1_write 3:write_bandwidth_kb: 2658.00
fedora-42-xfce_private_rnd4k_q1t1_read 3:read_bandwidth_kb: 8415.00
fedora-42-xfce_private_rnd4k_q1t1_write 3:write_bandwidth_kb: 784.00
fedora-42-xfce_volatile_seq1m_q8t1_read 3:read_bandwidth_kb: 416763.00
fedora-42-xfce_volatile_seq1m_q8t1_write 3:write_bandwidth_kb: 112648.00
fedora-42-xfce_volatile_seq1m_q1t1_read 3:read_bandwidth_kb: 319395.00
fedora-42-xfce_volatile_seq1m_q1t1_write 3:write_bandwidth_kb: 78328.00
fedora-42-xfce_volatile_rnd4k_q32t1_read 3:read_bandwidth_kb: 44282.00
fedora-42-xfce_volatile_rnd4k_q32t1_write 3:write_bandwidth_kb: 4307.00
fedora-42-xfce_volatile_rnd4k_q1t1_read 3:read_bandwidth_kb: 7956.00
fedora-42-xfce_volatile_rnd4k_q1t1_write 3:write_bandwidth_kb: 1667.00

This tests if volume works, but more importantly if all "unsafe" operations are blocked when its VM is running: - cloning to another volume - using as a source volume for snapshot The test has also commented out part about a backup - but that currently is blocked in the backup code directly. QubesOS/qubes-issues#8767

rustybird reviewed Jun 29, 2025

View reviewed changes

marmarek force-pushed the tests-no-snapshot branch 2 times, most recently from e54ed61 to 4d85ce0 Compare July 3, 2025 13:56

marmarek added the openqa-pending label Jul 3, 2025

This was referenced Jul 3, 2025

Add Arch packaging QubesOS/qubes-core-admin-client#332

Open

Improve device category description QubesOS/qubes-core-admin-client#362

Merged

marmarek force-pushed the tests-no-snapshot branch 5 times, most recently from 0cd5777 to 40763a4 Compare July 4, 2025 10:54

marmarek force-pushed the tests-no-snapshot branch from 40763a4 to 5b02db6 Compare July 4, 2025 17:34

marmarek merged commit 4f46ce3 into QubesOS:main Jul 4, 2025
1 of 3 checks passed

marmarek deleted the tests-no-snapshot branch July 19, 2025 21:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

tests: add an integration test for no-revisions volume #691

tests: add an integration test for no-revisions volume #691

Uh oh!

marmarek commented Jun 29, 2025

Uh oh!

codecov bot commented Jun 29, 2025 •

edited

Loading

Uh oh!

rustybird Jun 29, 2025

Uh oh!

qubesos-bot commented Jul 3, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

tests: add an integration test for no-revisions volume #691

tests: add an integration test for no-revisions volume #691

Uh oh!

Conversation

marmarek commented Jun 29, 2025

Uh oh!

codecov bot commented Jun 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

rustybird Jun 29, 2025

Choose a reason for hiding this comment

Uh oh!

qubesos-bot commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

OpenQA test summary

New failures, excluding unstable

Failed tests

Fixed failures

Unstable tests

Performance Tests

Performance degradation:

Remaining performance tests:

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Jun 29, 2025 •

edited

Loading

qubesos-bot commented Jul 3, 2025 •

edited

Loading