test: regenerate guppy_opt examples, and count gates #1249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acl-cqc
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1249 +/- ##
==========================================
- Coverage 79.06% 78.87% -0.19%
==========================================
Files 160 160
Lines 20421 20420 -1
Branches 19489 19489
==========================================
- Hits 16145 16106 -39
- Misses 3289 3324 +35
- Partials 987 990 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Nov 11, 2025
aborgna-q
approved these changes
Nov 12, 2025
tket-qsystem/tests/guppy_opt.rs
Outdated
| #[case::simple_cx(guppy_simple_cx(), (4, 2))] | ||
| #[cfg_attr(miri, ignore)] // Opening files is not supported in (isolated) miri | ||
| fn optimise_guppy(#[case] mut hugr: Hugr) { | ||
| fn optimise_guppy(#[case] mut hugr: Hugr, #[case] before: (usize, usize)) { |
Collaborator
There was a problem hiding this comment.
Try to document the tuple values?
It could be two parameters, or a helper Counts struct instead
Suggested change
| fn optimise_guppy(#[case] mut hugr: Hugr, #[case] before: (usize, usize)) { | |
| fn optimise_guppy(#[case] mut hugr: Hugr, #[case] before @ (_non_alloc, _alloc): (usize, usize)) { |
tket-qsystem/tests/guppy_opt.rs
Outdated
| #[case::nested(guppy_nested(), (6, 3))] | ||
| #[case::ranges(guppy_ranges(), (8, 4))] | ||
| #[case::simple_cx(guppy_simple_cx(), (0, 0))] | ||
| #[case::simple_cx(guppy_simple_cx(), (4, 2))] |
CalMacCQ
reviewed
Nov 12, 2025
tket-qsystem/tests/guppy_opt.rs
Outdated
| load_guppy_circuit("simple_cx") | ||
| } | ||
|
|
||
| fn count_gates(h: &impl HugrView) -> (usize, usize) { |
Contributor
There was a problem hiding this comment.
Could be nice to have a comment explaining what this is counting and why.
As we dicussed in person it could be nice to have a map with keys as OpType and number of instances of the optypes values
CalMacCQ
approved these changes
Nov 12, 2025
aborgna-q
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first part here is identical to examples from #1221 but I also needed myself. The second part....well, revealed why we need the first (I think updating to include Quantinuum/guppylang#1311 is particularly important) - DCE was taking out the gates because we were not doing anything to keep the
resultops (!).