Skip to content

Conversation

@aborgna-q
Copy link
Collaborator

@aborgna-q aborgna-q commented Dec 9, 2025

There can only be one pyo3 dependency version in the whole workspace since it depends on the shared libpython library, so breaking the supported versions is a breaking change.

drive-by: Bump other outdated internal dependencies.

BREAKING CHANGE: pyo3 dependency now requires 0.27

@aborgna-q aborgna-q requested a review from a team as a code owner December 9, 2025 13:28
@aborgna-q aborgna-q requested a review from acl-cqc December 9, 2025 13:28
@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

❌ Patch coverage is 4.76190% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.36%. Comparing base (4f021a7) to head (0101958).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
hugr-model/src/v0/ast/python.rs 0.00% 10 Missing ⚠️
hugr-model/src/v0/mod.rs 0.00% 10 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2736   +/-   ##
=======================================
  Coverage   83.36%   83.36%           
=======================================
  Files         267      267           
  Lines       52505    52505           
  Branches    47214    47214           
=======================================
  Hits        43773    43773           
  Misses       6354     6354           
  Partials     2378     2378           
Flag Coverage Δ
python 88.77% <ø> (ø)
rust 82.76% <4.76%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aborgna-q aborgna-q requested review from doug-q and removed request for acl-cqc December 10, 2025 10:32
@aborgna-q aborgna-q added this pull request to the merge queue Dec 10, 2025
Merged via the queue into main with commit c1e05e7 Dec 10, 2025
29 of 30 checks passed
@aborgna-q aborgna-q deleted the ab/bump-pyo3 branch December 10, 2025 12:31
@hugrbot hugrbot mentioned this pull request Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants