Skip to content

Update backend configuration for including and excluding buckets #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 30, 2025

Conversation

DenisaCG
Copy link
Member

@DenisaCG DenisaCG commented Jul 24, 2025

Follow-up to #89.

Update backend configuration to allow users to specify a list of drives to include or exclude from the drives filebrowser upon starting JupyterLab.

The config now contains two new fields, excluded_drives and included_drives, through which users can define a smaller set of drives they want to launch JupyterLab with. The given list of drives will be used to populate the UI for the drives manager linked in the above PR. As such, the user will still have control over their full set of buckets and will be able to add drives back to the filebrowser from the excluded list, as well as remove others from the included list.

Although both fields are present, only one of them is needed when configuring the drives list - they are just meant to give users a way to easily define the shortest list (e.g.: include only these three drives and exclude all else, opposed to exclude this long list of drives).

@DenisaCG DenisaCG self-assigned this Jul 24, 2025
@DenisaCG DenisaCG added the enhancement New feature or request label Jul 24, 2025
@DenisaCG DenisaCG marked this pull request as draft July 24, 2025 15:19
Copy link

Binder 👈 Launch a Binder on branch DenisaCG/jupyter-drives/include_exclude_config

@DenisaCG DenisaCG marked this pull request as ready for review July 25, 2025 16:13
@DenisaCG DenisaCG requested a review from afshin July 25, 2025 16:29
Copy link
Member

@afshin afshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This looks good.

If we get some validation from people who deploy this asking for some refinement we can do a follow-on PR, but this looks complete to me.

@afshin afshin merged commit 322d6b1 into QuantStack:main Jul 30, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants