Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove summer and use Africa #12

Merged
merged 1 commit into from
Jul 2, 2023
Merged

remove summer and use Africa #12

merged 1 commit into from
Jul 2, 2023

Conversation

Smit-create
Copy link
Member

No description provided.

@Smit-create
Copy link
Member Author

#11 (comment)

@Smit-create Smit-create requested a review from HumphreyYang July 1, 2023 10:59
@HumphreyYang
Copy link
Contributor

Many thanks @Smit-create!

Hi @mmcky, would you like me and @Smit-create to take charge of merging for now? We will do a cross-check before merging.

@mmcky
Copy link
Contributor

mmcky commented Jul 2, 2023

@HumphreyYang the workflow I recommend is to go ahead and merge (cc @Smit-create and @HumphreyYang) the exercises as soon as they are ready.

We can then organise a final review once you think they are ready to go.

Thanks for your help in pushing this forward.

@mmcky
Copy link
Contributor

mmcky commented Jul 2, 2023

Another reason for this is notebooks are hard to diff and review in github so PR's aren't that effective (other than managing collisions) in this context.

@HumphreyYang HumphreyYang merged commit aca3af4 into main Jul 2, 2023
@HumphreyYang HumphreyYang deleted the i-11 branch July 2, 2023 00:22
@HumphreyYang
Copy link
Contributor

Another reason for this is notebooks are hard to diff and review in github so PR's aren't that effective (other than managing collisions) in this context.

Many thanks @mmcky. The workflow sounds great to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants