Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: Refactor graphviz figures to be lecture_specific figures.ipynb assets #424

Merged
merged 7 commits into from
Apr 22, 2024
Merged

MAINT: Refactor graphviz figures to be lecture_specific figures.ipynb assets #424

merged 7 commits into from
Apr 22, 2024

Conversation

mmcky
Copy link
Contributor

@mmcky mmcky commented Apr 17, 2024 •
edited
Loading

This PR migrates the relevant sections of _static/lecture_specific/graphviz to be contained in figures.ipynb notebooks in

  • markov_chains_I
  • markov_chains_II
  • networks
  • lake_model

so the figures are directly associated with the lectures in which they appear.

This commits both the png asset and the text tikz output.

Fixes #422

@netlify Netlify
Copy link

netlify bot commented Apr 17, 2024 •
edited
Loading

✅ Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
🔨 Latest commit 2077d93
🔍 Latest deploy log https://app.netlify.com/sites/taupe-gaufre-c4e660/deploys/6625cba2e30cf700086d89ce
😎 Deploy Preview https://deploy-preview-424--taupe-gaufre-c4e660.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mmcky mmcky marked this pull request as ready for review April 17, 2024 05:57
@mmcky mmcky requested review from kp992 and HumphreyYang April 17, 2024 05:57
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 17, 2024 •
edited
Loading

🚀 Deployed on https://6625cd881f63a43648e9cfee--taupe-gaufre-c4e660.netlify.app

@github-actions github-actions bot temporarily deployed to pull request April 17, 2024 06:05 Inactive
kp992
kp992 approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@kp992 kp992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mmcky, this looks great!

@mmcky mmcky requested a review from jstac April 22, 2024 02:24
@mmcky
Copy link
Contributor Author

mmcky commented Apr 22, 2024

@jstac this is ready for your final review and merge.

@mmcky mmcky mentioned this pull request Apr 22, 2024
Merged
@jstac
Copy link
Contributor

jstac commented Apr 22, 2024

Many thanks @mmcky , much appreciated. Please merge when ready.

@github-actions github-actions bot temporarily deployed to pull request April 22, 2024 02:38 Inactive
@mmcky
Copy link
Contributor Author

mmcky commented Apr 22, 2024

  • checked paths in the lectures for graphviz and doesn't appear to be referenced. Merging this now.

@mmcky mmcky merged commit c879389 into main Apr 22, 2024
6 checks passed
@mmcky mmcky deleted the refactor-graphviz branch April 22, 2024 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kp992 kp992 kp992 approved these changes

@HumphreyYang HumphreyYang Awaiting requested review from HumphreyYang

@jstac jstac Awaiting requested review from jstac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[graphviz] refactor _static/graphviz notebook into figures.ipynb
3 participants
@mmcky @jstac @kp992