Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address comments for inflation_history lecture #407

Merged
merged 5 commits into from
Mar 25, 2024
Merged

Address comments for inflation_history lecture #407

merged 5 commits into from
Mar 25, 2024

Conversation

Jiarui-ZH
Copy link
Contributor

This update addresses the comments and suggestions made in QuantEcon/reading-group-2024#17. The following updates were made:

  • comment about xlrd added
  • pep 8 capitalised first words in comments.
  • Figure 4.2 -- axis title updated
  • variables such as df_Aus made lowercase
  • legend updated for Figures 4.3 and 4.5

@netlify Netlify
Copy link

netlify bot commented Mar 21, 2024 •
edited
Loading

✅ Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
🔨 Latest commit c1d24a8
🔍 Latest deploy log https://app.netlify.com/sites/taupe-gaufre-c4e660/deploys/6600e94790aed600080a79fe
😎 Deploy Preview https://deploy-preview-407--taupe-gaufre-c4e660.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Jiarui-ZH Jiarui-ZH closed this Mar 21, 2024
@Jiarui-ZH Jiarui-ZH reopened this Mar 21, 2024
mmcky
mmcky requested changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@mmcky mmcky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Jiarui-ZH for setting up this PR. I have made some minor comments

@Jiarui-ZH
Copy link
Contributor Author

Thank you for the suggestions @mmcky, I have made updates to address the suggestions mentioned

@mmcky
Copy link
Contributor

mmcky commented Mar 25, 2024

@Jiarui-ZH can you please delete .ipynb_checkpoints/README-checkpoint.md

@mmcky
Copy link
Contributor

mmcky commented Mar 25, 2024

thanks @Jiarui-ZH

@jstac this is ready for review

@mmcky mmcky requested a review from jstac March 25, 2024 06:25
@mmcky mmcky added the ready label Mar 25, 2024
@jstac
Copy link
Contributor

jstac commented Mar 25, 2024

Many thanks @Jiarui-ZH ! Thanks also @mmcky

@jstac jstac merged commit ba01860 into QuantEcon:main Mar 25, 2024
5 checks passed
@Jiarui-ZH Jiarui-ZH deleted the update_inflation_history branch March 25, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmcky mmcky mmcky requested changes

@jstac jstac Awaiting requested review from jstac

Assignees
No one assigned
Labels
ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jiarui-ZH @mmcky @jstac