Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote lectures to the intro series and update related files #405

Merged
merged 11 commits into from
Mar 23, 2024

Conversation

HumphreyYang
Copy link
Collaborator

Update files and lectures requested by Tom from the sandpit repository.

Copy link

netlify bot commented Mar 18, 2024

Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
🔨 Latest commit a60bd2e
🔍 Latest deploy log https://app.netlify.com/sites/taupe-gaufre-c4e660/deploys/65fe8b3488cbcc000867df58
😎 Deploy Preview https://deploy-preview-405--taupe-gaufre-c4e660.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mmcky
Copy link
Contributor

mmcky commented Mar 18, 2024

@HumphreyYang I just enabled build failure reports for LaTeX so you can see the execution error for

/home/runner/work/lecture-python-intro/lecture-python-intro/lectures/ak2.md: WARNING: Notebook exception traceback saved in: /home/runner/work/lecture-python-intro/lecture-python-intro/_build/latex/reports/ak2.err.log

@HumphreyYang
Copy link
Collaborator Author

Dear @thomassargent30 and @mmcky,

I have cleared the error from the code, and the error message indicates that the build is failing due to missing references. It should be building once the references are updated.

Thank you so much for your help.

Best,
Humphrey

@mmcky
Copy link
Contributor

mmcky commented Mar 18, 2024

@HumphreyYang LaTeX is failing to build the pdf -- but the execution issue seems to be fixed. Often the culprit is double equation environments. I will take a look through later this morning to see if I can spot the issue.

@HumphreyYang
Copy link
Collaborator Author

@HumphreyYang LaTeX is failing to build the pdf -- but the execution issue seems to be fixed. Often the culprit is double equation environments. I will take a look through later this morning to see if I can spot the issue.

Many thanks @mmcky, there are some references that are not in the .bib file at the moment. Tom has kindly offered help to add them. Perhaps we can wait until Tom committed his changes.

@mmcky
Copy link
Contributor

mmcky commented Mar 19, 2024

@HumphreyYang LaTeX is failing to build the pdf -- but the execution issue seems to be fixed. Often the culprit is double equation environments. I will take a look through later this morning to see if I can spot the issue.

Many thanks @mmcky, there are some references that are not in the .bib file at the moment. Tom has kindly offered help to add them. Perhaps we can wait until Tom committed his changes.

thanks @HumphreyYang -- there are many instances where align needs to be changed to aligned when in between $$ as align is an equation environment so causes LaTeX compilation issues due to nested equations.

  • run a search and replace align with aligned

Copy link

github-actions bot commented Mar 19, 2024

@github-actions github-actions bot temporarily deployed to pull request March 19, 2024 21:23 Inactive
@mmcky
Copy link
Contributor

mmcky commented Mar 20, 2024

@HumphreyYang this just has a minor issue

/home/runner/work/lecture-python-intro/lecture-python-intro/lectures/cagan_adaptive.md:81: ERROR: Unknown interpreted text role "citet"

@github-actions github-actions bot temporarily deployed to pull request March 21, 2024 05:33 Inactive
@github-actions github-actions bot temporarily deployed to pull request March 21, 2024 06:23 Inactive
@github-actions github-actions bot temporarily deployed to pull request March 22, 2024 07:05 Inactive
@github-actions github-actions bot temporarily deployed to pull request March 23, 2024 08:05 Inactive
@mmcky mmcky added review and removed in-work labels Mar 23, 2024
@mmcky
Copy link
Contributor

mmcky commented Mar 23, 2024

@thomassargent30 @HumphreyYang thanks for your edits and contribution.

This is getting merged as @thomassargent30 would like to use it early next week. (cc @jstac)

@mmcky mmcky merged commit 46e870e into main Mar 23, 2024
6 checks passed
@mmcky mmcky deleted the promote-sandpit branch March 23, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants