[cagan_adaptive] update the editorial suggestions #399

longye-tian · 2024-03-13T10:58:37Z

Update some of the issues in #392, specifically:

change the name create_cagan_model to create_cagan_adaptive_model
Change 'monetarist theory of price level' to 'A monetarist theory of price level'
Remove the extra quotation mark in the second sentences
Change 'endogenous input' to 'exogenous input'

Solve some of the issues in #392, specifically: - change the name `create_cagan_model` to `create_cagan_adaptive_model` - Change 'monetarist theory of price level' to 'A monetarist theory of price level' - Remove the extra quotation mark in the second sentences - Change 'endogenous input' to 'exogenous input'

netlify · 2024-03-13T10:58:50Z

✅ Deploy Preview for taupe-gaufre-c4e660 ready!

Name	Link
🔨 Latest commit	`3825e85`
🔍 Latest deploy log	https://app.netlify.com/sites/taupe-gaufre-c4e660/deploys/65f34fbdf9e3b40008cb4e5c
😎 Deploy Preview	https://deploy-preview-399--taupe-gaufre-c4e660.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions · 2024-03-13T11:06:22Z

🚀 Deployed on https://65f351809af916220bcd120a--taupe-gaufre-c4e660.netlify.app

longye-tian · 2024-03-14T08:38:43Z

Dear @jstac (John),

I've made some updates a few suggestions to issue #392. When you have a moment, could you please take a look?

Best regards,
Lonyge

jstac · 2024-03-14T11:29:22Z

lectures/cagan_adaptive.md

@@ -16,13 +16,13 @@ kernelspec:
 ## Introduction


-This lecture is a sequel or prequel to another lecture {doc}`monetarist theory of  price levels <cagan_ree>`.
+This lecture is a sequel or prequel to another lecture {doc}`A monetarist theory of  price levels <cagan_ree>`.


Thanks @longye-tian .

How about "This lecture is a sequel or prequel to the lecture {doc}cagan_ree.

jstac · 2024-03-14T11:30:20Z

lectures/cagan_adaptive.md


-Like the model in this lecture {doc}`monetarist theory of  price levels <cagan_ree>`, the model asserts that when a government persistently spends more than it collects in taxes and prints money to finance the shortfall, it puts upward pressure on the price level and generates persistent inflation.
+Like the model in this lecture {doc}`A monetarist theory of  price levels <cagan_ree>`, the model asserts that when a government persistently spends more than it collects in taxes and prints money to finance the shortfall, it puts upward pressure on the price level and generates persistent inflation.


"Like the model in {doc}cagan_ree, the model..."

jstac · 2024-03-14T11:31:00Z

lectures/cagan_adaptive.md


-Instead of the "perfect foresight" or "rational expectations" version of the model in this lecture {doc}`monetarist theory of  price levels <cagan_ree>`, our model in the present lecture is an "adaptive expectations"  version of a model that Philip Cagan {cite}`Cagan`  used to study the monetary dynamics of hyperinflations.  
+Instead of the "perfect foresight" or "rational expectations" version of the model in this lecture {doc}`A monetarist theory of  price levels <cagan_ree>`, our model in the present lecture is an "adaptive expectations"  version of a model that Philip Cagan {cite}`Cagan`  used to study the monetary dynamics of hyperinflations.  


Same comment.

jstac · 2024-03-14T11:31:25Z

lectures/cagan_adaptive.md

@@ -278,7 +278,7 @@ $$ (eq:notre)
 This outcome is typical in models in which adaptive expectations hypothesis like equation {eq}`eq:adaptexpn` appear as a
 component.  

-In this lecture {doc}`monetarist theory of the price level <cagan_ree>`, we studied a version of the model that replaces hypothesis {eq}`eq:adaptexpn` with
+In this lecture {doc}`A monetarist theory of the price level <cagan_ree>`, we studied a version of the model that replaces hypothesis {eq}`eq:adaptexpn` with


Same comment.

jstac · 2024-03-14T11:31:49Z

lectures/cagan_adaptive.md

@@ -431,7 +431,7 @@ $$
     \end{cases}
 $$

-Notice that  we studied exactly this experiment  in a rational expectations version of the model in this lecture {doc}`monetarist theory of the price level <cagan_ree>`.
+Notice that  we studied exactly this experiment  in a rational expectations version of the model in this lecture {doc}`A monetarist theory of the price level <cagan_ree>`.


Same comment.

jstac · 2024-03-14T11:32:00Z

lectures/cagan_adaptive.md

@@ -442,7 +442,7 @@ So by comparing outcomes across the two lectures, we can learn about consequence
 π_seq_1, Eπ_seq_1, m_seq_1, p_seq_1 = solve_and_plot(md, μ_seq_1)
 ```

-We invite the reader to compare outcomes with those under rational expectations studied in another lecture {doc}`monetarist theory of  price levels <cagan_ree>`.
+We invite the reader to compare outcomes with those under rational expectations studied in another lecture {doc}`A monetarist theory of  price levels <cagan_ree>`.


Same comment.

jstac · 2024-03-14T11:35:14Z

Many thanks @longye-tian . I've suggested one repeated change:

{doc}`file_name`

will insert the lecture title, which is more robust (e.g., if we change the name of the lecture, we don't need to change it here as well).

This commit modifies the hyperlink title using {doc}`file_name`

longye-tian · 2024-03-14T12:31:29Z

Dear John, @jstac,

Thank you very much for your valuable suggestion!

Following your advice, I've updated all the hyperlink titles in this lecture to the format:

{doc}`file_name`

I appreciate your help.

Best regards ❤️
Longye

jstac · 2024-03-14T19:58:45Z

Thanks @longye-tian , much appreciated.

github-actions bot temporarily deployed to pull request March 13, 2024 11:06 Inactive

longye-tian changed the title ~~Update cagan_adaptive.md~~ [cagan_adaptive] update the editorial suggestions #392 Mar 13, 2024

longye-tian changed the title ~~[cagan_adaptive] update the editorial suggestions #392~~ [cagan_adaptive] update the editorial suggestions Mar 13, 2024

longye-tian requested a review from jstac March 14, 2024 08:35

jstac reviewed Mar 14, 2024

View reviewed changes

update the hyperlink title

486ee3e

This commit modifies the hyperlink title using {doc}`file_name`

github-actions bot temporarily deployed to pull request March 14, 2024 12:35 Inactive

misc

3825e85

github-actions bot temporarily deployed to pull request March 14, 2024 19:35 Inactive

jstac merged commit 5d1472e into main Mar 14, 2024
6 checks passed

jstac deleted the update_cagan_adaptive branch March 14, 2024 19:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[cagan_adaptive] update the editorial suggestions #399

[cagan_adaptive] update the editorial suggestions #399

longye-tian commented Mar 13, 2024 •

edited

Loading

netlify bot commented Mar 13, 2024 •

edited

Loading

github-actions bot commented Mar 13, 2024 •

edited

Loading

longye-tian commented Mar 14, 2024

jstac Mar 14, 2024

jstac Mar 14, 2024

jstac Mar 14, 2024

jstac Mar 14, 2024

jstac Mar 14, 2024

jstac Mar 14, 2024

jstac commented Mar 14, 2024

longye-tian commented Mar 14, 2024 •

edited

Loading

jstac commented Mar 14, 2024


		Like the model in this lecture {doc}`monetarist theory of price levels <cagan_ree>`, the model asserts that when a government persistently spends more than it collects in taxes and prints money to finance the shortfall, it puts upward pressure on the price level and generates persistent inflation.
		Like the model in this lecture {doc}`A monetarist theory of price levels <cagan_ree>`, the model asserts that when a government persistently spends more than it collects in taxes and prints money to finance the shortfall, it puts upward pressure on the price level and generates persistent inflation.


		Instead of the "perfect foresight" or "rational expectations" version of the model in this lecture {doc}`monetarist theory of price levels <cagan_ree>`, our model in the present lecture is an "adaptive expectations" version of a model that Philip Cagan {cite}`Cagan` used to study the monetary dynamics of hyperinflations.
		Instead of the "perfect foresight" or "rational expectations" version of the model in this lecture {doc}`A monetarist theory of price levels <cagan_ree>`, our model in the present lecture is an "adaptive expectations" version of a model that Philip Cagan {cite}`Cagan` used to study the monetary dynamics of hyperinflations.

[cagan_adaptive] update the editorial suggestions #399

[cagan_adaptive] update the editorial suggestions #399

Conversation

longye-tian commented Mar 13, 2024 • edited Loading

netlify bot commented Mar 13, 2024 • edited Loading

✅ Deploy Preview for taupe-gaufre-c4e660 ready!

github-actions bot commented Mar 13, 2024 • edited Loading

longye-tian commented Mar 14, 2024

jstac Mar 14, 2024

Choose a reason for hiding this comment

jstac Mar 14, 2024

Choose a reason for hiding this comment

jstac Mar 14, 2024

Choose a reason for hiding this comment

jstac Mar 14, 2024

Choose a reason for hiding this comment

jstac Mar 14, 2024

Choose a reason for hiding this comment

jstac Mar 14, 2024

Choose a reason for hiding this comment

jstac commented Mar 14, 2024

longye-tian commented Mar 14, 2024 • edited Loading

jstac commented Mar 14, 2024

longye-tian commented Mar 13, 2024 •

edited

Loading

netlify bot commented Mar 13, 2024 •

edited

Loading

github-actions bot commented Mar 13, 2024 •

edited

Loading

longye-tian commented Mar 14, 2024 •

edited

Loading