-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[intro_supply_demand] Adding to supply and demand lecture #372
Conversation
✅ Deploy Preview for taupe-gaufre-c4e660 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hey @mmcky , is this failing due to broken links? That seems to be the message in the log file... |
That's right @jstac -- the
Looks like FYI - the |
Thanks @mmcky . I've pushed a trivial change to generate a build w/o the link checker. |
No worries @jstac -- also they are separate workflows so if you take a look at the box at the bottom of the PR ![]() you will see the |
To do:
|
@mmcky Tom has given the green light on these changes. Would you mind to proofread and then change the colors below so they are unified with the colors above (same colors for supply curve throughout, demand curve throughout, etc.)? |
This PR aims to close #358 and #355 Remaining tasks:
@mmcky Would you mind to implement these changes? |
I have started the following discussion https://github.com/orgs/QuantEcon/discussions/128 to run some ideas around how to select colours for plots and figures in a more "style" friendly and consistent way across lectures. |
def inverse_supply(self, q): | ||
return self.s_0 + self.s_1 * q | ||
def create_market(d_0=1.0, d_1=0.6, s_0=0.1, s_1=0.4): | ||
return Market(d_0=d_0, d_1=d_1, s_0=s_0, s_1=s_1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add "The function below creates an instance of a Market
namedtuple with default values."
lectures/intro_supply_demand.md
Outdated
``` | ||
|
||
Let's create an instance. | ||
We can now define some functions that `create` and `operate` on these Market parameters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused. Don't we already have the code in 670 above, in line 363?
Either way, I suggest dropping the back ticks, which should be reserved for code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry @jstac I prematurely pushed. Working on the final proof
read now :-).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this duplication is no resolved after 5e2d75b. I had implemented the namedtuple
in the exercise first and was propagating it to the text.
Great work, thanks @mmcky.
Perhaps you could ask someone to embed the figures in numbered figure environments. It's not a big deal but it does make it easier to reference figures. |
thanks @jstac
This is now back to blue for the area (default matplotlib style)
Good catch. This is now green.
All figures are now numbered with captions except those figures in the exercises. I didn't think they needed captions and/or references but let me know if you think they do. 👍 |
Perfect, thanks @mmcky !! I'll leave you to merge when ready (and please make it live). |
Adding introductory material to the start, for readers from computer science and other backgrounds.