ENH: move inflation_history to economic data #370

mmcky · 2024-02-15T08:44:19Z

This PR moves the inflation_history lecture up to section on Economic Data

This PR also reviews inflation_history and makes the following adjustments

netlify · 2024-02-15T08:44:23Z

✅ Deploy Preview for taupe-gaufre-c4e660 ready!

Name	Link
🔨 Latest commit	`c2f0f74`
🔍 Latest deploy log	https://app.netlify.com/sites/taupe-gaufre-c4e660/deploys/65cf1e06c91e5f000876a429
😎 Deploy Preview	https://deploy-preview-370--taupe-gaufre-c4e660.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions · 2024-02-15T08:53:16Z

🚀 Deployed on https://65ce9cddf900a14d3ef7a721--taupe-gaufre-c4e660.netlify.app

github-actions · 2024-02-15T23:58:16Z

🚀 Deployed on https://65cf1ff43573be9663fdda41--taupe-gaufre-c4e660.netlify.app

mmcky · 2024-02-16T02:04:10Z

lectures/inflation_history.md


-Each governent  stoppped printing money to pay for goods and services once again made its currency  convertible  to the US dollar or the UK pound, thereby vitually  to gold.
+Each government stopped printing money to pay for goods and services once again which made its currency convertible to the US dollar or the UK pound.


@jstac this is perhaps the most controversial edit re: gold comment. Should we keep thereby vitally to gold.

Thanks @mmcky . I think your sentence is good but please change "which" to "and".

jstac · 2024-02-16T02:37:24Z

lectures/inflation_history.md


 ```{code-cell} ipython3
 import numpy as np
 import pandas as pd
 import matplotlib.pyplot as plt
+plt.matplotlib.rcParams['figure.figsize'] = (12,8)


Is this not set to a standard value in the config file?

this matplotlib config needs to be initialised each time matplotlib is imported. We could add a global scale to the general config but that doesn't ensure the png files are high enough quality in all cases. Tricky one.

FWIW - we could look at using https://matplotlib.org/1.3.1/users/customizing.html and maintain a config file as it isn't essential for rendering in the notebook (just displaying on the website). This will add a bit of complexity around deployment though as it would need to be "installed"

jstac · 2024-02-16T02:38:07Z

lectures/inflation_history.md


-As usual, we'll start by importing some Python modules.
+We then import the Python modules we need.


I think our convention is to have all imports and installs at the top. Shall we move this and the previous cell up and modify the text?

jstac · 2024-02-16T02:41:05Z

lectures/inflation_history.md

+```
+
+Now we write plotting functions so we can plot the price level, exchange rates, 
+and inflation rates, for each country of interest.


I think it's good practice for us to name the funtions that will be hidden, and say roughly what they do, so readers who don't want to open the cell can still understand the code that follows.

will add to manual.quantecon.org

https://github.com/QuantEcon/QuantEcon.manual/commit/61566b5f675b794a893bdff28654594160d80d09

jstac · 2024-02-16T02:42:12Z

lectures/inflation_history.md


-For each country, the second graph plots a three-month moving average of the inflation rate defined as $p_t - p_{t-1}$.
+For each country, the second graph plots a centered three-month moving average of the inflation rate defined as $\frac{p_{t-1} + p_t + p_{t+1}}{3}$.


Is this a moving average of prices or of the inflation rate?

inflation rate -- as the ma code is part of pr_plot or Plots for inflation rates

jstac · 2024-02-16T02:43:28Z

lectures/inflation_history.md

 plt.show()
 ```

 ## Starting and Stopping Big Inflations

-It is  striking  how **quickly**  (log) price levels in Austria, Hungary, Poland,
-and Germany leveled off after  rising so quickly.
+It is striking how **quickly** (log) price levels in Austria, Hungary, Poland, and Germany leveled off after rising so quickly.


Bold is for defintions and italics is for emphasis: https://manual.quantecon.org/styleguide/writing.html#emphasis-and-definitions

will change to *

jstac · 2024-02-16T02:53:17Z

Thanks @mmcky , great changes! I've flagged some small issues above. Also, could you please bring the headings and axis labels in line with the manual?

Would you mind to get rid of all ax.spines[['right', 'top']].set_visible(False) type code, so that all figs are in a box? That way they'll all look the same.

Suggestion: "The graph shows..." -> "Figure xx shows..."

mmcky · 2024-02-16T02:56:08Z

Thanks @jstac

Would you mind to get rid of all ax.spines[['right', 'top']].set_visible(False) type code, so that all figs are in a box? That way they'll all look the same.

Ah I went the other way and added it to all (in an effort to minimise lines) 😄 -- but I will remove the ax.spines code so there is a box around every figure.

jstac · 2024-02-16T02:59:40Z

Ah I went the other way and added it to all (in an effort to minimise lines) 😄 -- but I will remove the ax.spines code so there is a box around every figure.

Totally reasonable -- I like minimal -- but some of the figs have axis numbers on the right, so they end up being three sided, which looks a bit odd.

I think it's nice if every figure has a uniform style, and we can achieve this with boxes...

mmcky · 2024-02-16T03:28:53Z

Suggestion: "The graph shows..." -> "Figure xx shows..."

Great. I updated this type of text to numref in a number of places when referencing a specific graph. There are some instances of graph that are more generally related to a group that I have left.

mmcky · 2024-02-16T04:21:57Z

thanks @jstac I think all round 2 feedback is now incorporated.

jstac · 2024-02-16T06:58:54Z

@mmcky please feel free to merge when you've made those last changes.

If it doesn't mess up the figures, perhaps we should also get rid of plt.rcParams.update({'font.size': 19}).

I think the lectures are smoother for readers if they don't hit messy commands at the very start of the lecture.

With figure sizes, let's strongly encourage people to stick with defaults unless they have a good reason not to --- and consider changing the defaults if we often need to deviate...

mmcky · 2024-02-16T08:26:07Z

thanks @jstac e22b9de fixes the within figure text to be in style with the QuantEcon manual.

mmcky · 2024-02-16T08:34:53Z

@jstac I have updated figures to

simplify matplotlib config that is requried
migrate figure text to use matplotlib labels for x and y

move inflation_history to economic data

2000192

mmcky added the ready label Feb 15, 2024

mmcky added 2 commits February 16, 2024 10:14

@mmcky edits and review

c3cf7d0

update to incorporate feedback in #371

2d2537c

mmcky closed this Feb 15, 2024

mmcky reopened this Feb 15, 2024

MAINT: update action versions for ci

3d1348d

github-actions bot temporarily deployed to pull request February 15, 2024 23:58 Inactive

minor edits and set standard figsize

dc7294f

github-actions bot temporarily deployed to pull request February 16, 2024 00:15 Inactive

use figsize from qe manual

4e7a5cc

github-actions bot temporarily deployed to pull request February 16, 2024 00:25 Inactive

mmcky added 2 commits February 16, 2024 11:54

adjust figsize,font globally and remove embedded figure text

bde157f

clean up old scale

c299b1d

github-actions bot temporarily deployed to pull request February 16, 2024 01:04 Inactive

reformat doc references to use titles

7c30fc8

github-actions bot temporarily deployed to pull request February 16, 2024 01:17 Inactive

mmcky added 3 commits February 16, 2024 12:46

@mmcky final edit

8ac4c70

update reference to figure

2d6fd93

fix fraction

3504ecd

mmcky commented Feb 16, 2024

View reviewed changes

FIX: add back in xlrd

bb18112

github-actions bot temporarily deployed to pull request February 16, 2024 02:18 Inactive

jstac reviewed Feb 16, 2024

View reviewed changes

mmcky added 2 commits February 16, 2024 14:29

incorporate round 2 feedback from @jstac

d99c031

fix missing word

931dc5b

github-actions bot temporarily deployed to pull request February 16, 2024 03:41 Inactive

fix github link

85eb7de

github-actions bot temporarily deployed to pull request February 16, 2024 04:02 Inactive

update lw=2 for more vivid lines in figures

c5cb66e

github-actions bot temporarily deployed to pull request February 16, 2024 04:17 Inactive

adjust within figure text to be in QuantEcon style

e22b9de

github-actions bot temporarily deployed to pull request February 16, 2024 08:33 Inactive

simplfiy matplotlib config + migrate fig text to labels

c2f0f74

github-actions bot temporarily deployed to pull request February 16, 2024 08:42 Inactive

mmcky merged commit 147d10f into main Feb 16, 2024
6 checks passed

mmcky deleted the update-toc branch February 16, 2024 23:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ENH: move inflation_history to economic data #370

ENH: move inflation_history to economic data #370

mmcky commented Feb 15, 2024 •

edited

Loading

netlify bot commented Feb 15, 2024 •

edited

Loading

github-actions bot commented Feb 15, 2024 •

edited

Loading

github-actions bot commented Feb 15, 2024 •

edited

Loading

mmcky Feb 16, 2024 •

edited

Loading

jstac Feb 16, 2024

jstac Feb 16, 2024

mmcky Feb 16, 2024

mmcky Feb 16, 2024

jstac Feb 16, 2024

jstac Feb 16, 2024

mmcky Feb 16, 2024

mmcky Feb 16, 2024

jstac Feb 16, 2024

mmcky Feb 16, 2024 •

edited

Loading

jstac Feb 16, 2024

mmcky Feb 16, 2024

jstac commented Feb 16, 2024

mmcky commented Feb 16, 2024

jstac commented Feb 16, 2024

mmcky commented Feb 16, 2024

mmcky commented Feb 16, 2024

jstac commented Feb 16, 2024

mmcky commented Feb 16, 2024

mmcky commented Feb 16, 2024 •

edited

Loading


		Each governent stoppped printing money to pay for goods and services once again made its currency convertible to the US dollar or the UK pound, thereby vitually to gold.
		Each government stopped printing money to pay for goods and services once again which made its currency convertible to the US dollar or the UK pound.


		As usual, we'll start by importing some Python modules.
		We then import the Python modules we need.


		For each country, the second graph plots a three-month moving average of the inflation rate defined as $p_t - p_{t-1}$.
		For each country, the second graph plots a centered three-month moving average of the inflation rate defined as $\frac{p_{t-1} + p_t + p_{t+1}}{3}$.

ENH: move inflation_history to economic data #370

ENH: move inflation_history to economic data #370

Conversation

mmcky commented Feb 15, 2024 • edited Loading

netlify bot commented Feb 15, 2024 • edited Loading

✅ Deploy Preview for taupe-gaufre-c4e660 ready!

github-actions bot commented Feb 15, 2024 • edited Loading

github-actions bot commented Feb 15, 2024 • edited Loading

mmcky Feb 16, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mmcky Feb 16, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jstac commented Feb 16, 2024

mmcky commented Feb 16, 2024

jstac commented Feb 16, 2024

mmcky commented Feb 16, 2024

mmcky commented Feb 16, 2024

jstac commented Feb 16, 2024

mmcky commented Feb 16, 2024

mmcky commented Feb 16, 2024 • edited Loading

mmcky commented Feb 15, 2024 •

edited

Loading

netlify bot commented Feb 15, 2024 •

edited

Loading

github-actions bot commented Feb 15, 2024 •

edited

Loading

github-actions bot commented Feb 15, 2024 •

edited

Loading

mmcky Feb 16, 2024 •

edited

Loading

mmcky Feb 16, 2024 •

edited

Loading

mmcky commented Feb 16, 2024 •

edited

Loading