Limit user contributions in a group by #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngrislain
reviewed
Dec 10, 2024
| ) -> DpParameters { | ||
| DpParameters { | ||
| epsilon, | ||
| delta, | ||
| tau_thresholding_share, | ||
| privacy_unit_max_multiplicity, | ||
| privacy_unit_max_multiplicity_share, | ||
| max_user_groups, |
There was a problem hiding this comment.
There is no notion of user in qrlew -> please align the naming e.g. max_group_per_privacy_unit or max_privacy_unit_groups
ngrislain
reviewed
Dec 10, 2024
src/differential_privacy/group_by.rs
Outdated
| &self, | ||
| epsilon: f64, | ||
| delta: f64, | ||
| max_user_groups: u64, |
There was a problem hiding this comment.
I don't know what a user is
ngrislain
reviewed
Dec 10, 2024
src/differential_privacy/group_by.rs
Outdated
| let right = left.clone(); | ||
|
|
||
| // Build an auto join to emulate a window function. | ||
| let columns_and_pu_and_rand: Vec<_> = columns_and_pu |
There was a problem hiding this comment.
Isolate the contrib limitation code
ngrislain
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this MR we limit the user contribution to at most cu groups when applying tau thresholding. cu is now a privacy parameter which by default is 1.