Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support multi stage dockerfile #1865

Open
wants to merge 4 commits into
base: staging
Choose a base branch
from

Conversation

jul-dan
Copy link
Contributor

@jul-dan jul-dan commented Apr 10, 2025

@RemiBonnet I have tested all these cases:

  • Create app/job/cronjob with no stage
  • Create app/job/cronjob with stage
  • Edit app/job/cronjob with from no stage to stage
  • Edit app/job/cronjob with from stage to no stage <-- Here I have an issue for cronjobs, it sends a stage whereas I remove the field value. I think it is due to job/cronjobs conflicts.
  • Clone app/job/cronjob with no stage
  • Clone app/job/cronjob with stage

What does this PR do?

https://qovery.atlassian.net/browse/QOV-69

PR Checklist

  • This PR introduces breaking change(s) and has been labeled as such
  • This PR introduces new store changes
  • I made sure the code is type safe (no any)

@RemiBonnet
Copy link
Member

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview cc1de7de-94e5-40f8-8e45-bc8986d9dfec storybook
/qovery preview 28c47145-c8e7-4b9d-8d9e-c65c95b48425 staging
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

The backlog never ends, be at peace with it

Copy link

nx-cloud bot commented Apr 10, 2025

View your CI Pipeline Execution ↗ for commit 293a633.

Command Status Duration Result
nx affected --target=test --parallel=3 --config... ❌ Failed 1m 48s View ↗
nx affected --target=lint --parallel=3 ✅ Succeeded 1m 4s View ↗
nx affected --target=build --parallel=3 ✅ Succeeded 10s View ↗
nx-cloud record -- npx nx format:check ✅ Succeeded 12s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-11 12:20:36 UTC

@jul-dan jul-dan requested a review from RemiBonnet April 11, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants