Fix for dust error when redeeming P2SH-B #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 16, 2020 17:02
…aused the Electrum nodes to fail with a 'dust' error. Ideally we need to redeem at least 700 sats in order to stand a chance of exceeding the dust threshold (3000 sats/kB).
… transaction is also rejected due to the 'dust' error. Note: we can probably skip this entire step, as the majority of the P2SA-B balance is needed to pay for its own transaction fee, even when refunded.
|
I've applied the same logic when refunding P2SH-B, as I ran a mainnet test and this was also failing with the same 'dust' error. As a result of the fix, the buyer is now refunded 1000 sats and the remaining 4000 sats are used to pay the transaction fee. Longer term it may be easier to just skip this entire step, as it's not achieving much. I see you've mentioned that in the comments. After applying this 1000 sat redemption, my mainnet trade was able to proceed to the next step (the P2SH-A refund).
|
|
Thanks for spotting this... Closing without merge as this was fixed as part of implementing what you spotted in PR #18 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have committed my fix for the 'dust' error #14 when attempting to redeem P2SH-B with a zero amount. It is now redeeming 1000 sats, which was enough to allow a mainnet transaction to progress and ultimately succeed.
The trade-off of this approach is that the seller receives an extra 1000 sats, rather than them being used as part of the fee. In my trade, the remaining 4000 sats were still enough for the transaction to be included in a block 9 hours later, and this delay didn't affect the trade in any noticeable way.
I'll completely understand if you want to come up with better fix than this, but since it worked correctly for me and unblocks a critical issue with the TradeBot, I figured I'd submit a pull request.