Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "ansi" feature for adding terminal colors on trace outputs #23

Merged
merged 4 commits into from
Jul 25, 2022
Merged

Add "ansi" feature for adding terminal colors on trace outputs #23

merged 4 commits into from
Jul 25, 2022

Conversation

sfleener
Copy link
Contributor

@sfleener sfleener commented Jul 25, 2022 •
edited
Loading

Fixes #21

Example terminal output:
image

QnnOkabayashi
QnnOkabayashi requested changes Jul 25, 2022
View reviewed changes
Copy link
Owner

@QnnOkabayashi QnnOkabayashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for contributing! Can you make sure that fmt and clippy have been run? I haven't set up CI yet :/

@sfleener
Copy link
Contributor Author

I double checked that fmt --all and clippy pass with no errors or warnings, including the new changes.

QnnOkabayashi
QnnOkabayashi reviewed Jul 25, 2022
View reviewed changes
@QnnOkabayashi
Copy link
Owner

Thanks for working on this!

@QnnOkabayashi QnnOkabayashi merged commit 45a5169 into QnnOkabayashi:master Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QnnOkabayashi QnnOkabayashi QnnOkabayashi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ANSI colors
2 participants
@sfleener @QnnOkabayashi