Skip to content

Refactor layout writing to avoid slice creation #15375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jphamata wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Refactor layout writing to avoid slice creation #15375

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
481f574
Refactor layout writing to avoid slice creation
jphamata Nov 26, 2025
45b6be9
Merge pull request #1 from jphamata/jphamata-patch-1
jphamata Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 16 additions & 21 deletions crates/cext/src/transpiler/transpile_layout.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,14 +106,12 @@ pub unsafe extern "C" fn qk_transpile_layout_initial_layout(
if let Some(out_initial_layout) = out_initial_layout {
// SAFETY: Per the documentation initial_layout must be a valid pointer with a sufficient
// allocation for the output array
unsafe {
let out_slice =
std::slice::from_raw_parts_mut(initial_layout, out_initial_layout.len());
out_slice
.iter_mut()
.zip(out_initial_layout.iter())
.for_each(|(dest, src)| *dest = src.0);
};
// Write directly to avoid creating references to uninitialized memory.
for (i, src) in out_initial_layout.iter().enumerate() {
unsafe {
initial_layout.add(i).write(src.0);
}
}
true
} else {
false
Expand Down Expand Up @@ -160,13 +158,12 @@ pub unsafe extern "C" fn qk_transpile_layout_output_permutation(
if let Some(permutation) = permutation {
// SAFETY: Per the documentation output_permutation must be a valid pointer with a sufficient
// allocation for the output array
unsafe {
let out_slice = std::slice::from_raw_parts_mut(output_permutation, permutation.len());
out_slice
.iter_mut()
.zip(permutation.iter())
.for_each(|(dest, src)| *dest = src.0);
};
// Write directly to avoid creating references to uninitialized memory.
for (i, src) in permutation.iter().enumerate() {
unsafe {
output_permutation.add(i).write(src.0);
}
}
true
} else {
false
Expand Down Expand Up @@ -214,12 +211,10 @@ pub unsafe extern "C" fn qk_transpile_layout_final_layout(
let result = layout.final_index_layout(filter_ancillas);
// SAFETY: Per the documentation final_layout must be a valid pointer with a sufficient
// allocation for the output array
unsafe {
let out_slice = std::slice::from_raw_parts_mut(final_layout, result.len());
out_slice
.iter_mut()
.zip(result.iter())
.for_each(|(dest, src)| *dest = src.0);
for (i, src) in result.iter().enumerate() {
unsafe {
final_layout.add(i).write(src.0);
}
}
}

Expand Down