-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Add qk_circuit_draw function to the C API
#15361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
eliarbel
wants to merge
72
commits into
Qiskit:main
Choose a base branch
from
eliarbel:c-api-circuit-drawer
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,558
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nger needed to import qiskit._accelerate, can simply call qc.draw(text2)
* Change the VisualizationElement::VerticalLine to hold a PackedInstruction reference * Fix capitalization of labels * Fix clippy * Correct drawing vertical line of a measure
This commit fixes several issues discovered via manual testing. Specifically: * Single bit wires - avoid printing `_1` for bits of length 1. For example `my_qr` instead of `my_qr_1` if `my_qr` is of length 1 * Changed some standard gate names to match those in the Python drawer * Count number of chars in label to account for Unicode chars properly when computing label length.
* Changed default names for qubit and clbit wires * Added support for anonymous bits * Fixed a bug with mapping clbit indices to `VisualizationMatrix` wires when `cregbunde=true`
Collaborator
|
One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 19696786623Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C API
Related to the C API
Changelog: New Feature
Include in the "Added" section of the changelog
on hold
Can not fix yet
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for circuit text drawing through the C API. It is based and blocked on #15357. See commit fefdd03 for the changes of this PR only.