Skip to content

Fix missing Qk prefix for C ExitCode (backport #14119) #14123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 28, 2025

Summary

Missed a Qk prefix for the ExitCode enum class, which should be called QkExitCode. This sort of problem will likely keep popping up since we're manually adding this prefix, until we get a solution like mozilla/cbindgen#1061.


This is an automatic backport of pull request #14119 done by [Mergify](https://mergify.com).

(cherry picked from commit 8c21753)
@mergify mergify bot requested a review from a team as a code owner March 28, 2025 13:27
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@github-actions github-actions bot added the Changelog: None Do not include in changelog label Mar 28, 2025
@github-actions github-actions bot added this to the 2.0.0 milestone Mar 28, 2025
@github-actions github-actions bot added the C API Related to the C API label Mar 28, 2025
@mtreinish mtreinish enabled auto-merge March 28, 2025 13:33
@coveralls
Copy link

Pull Request Test Coverage Report for Build 14130016115

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 11 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.002%) to 88.082%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 5 92.23%
crates/qasm2/src/parse.rs 6 97.61%
Totals Coverage Status
Change from base Build 14128040248: -0.002%
Covered Lines: 72745
Relevant Lines: 82588

💛 - Coveralls

@mtreinish mtreinish added this pull request to the merge queue Mar 28, 2025
Merged via the queue into stable/2.0 with commit 9cf2d99 Mar 28, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C API Related to the C API Changelog: None Do not include in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants