Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable programmatic config of polling timeout #28

Merged
merged 12 commits into from
Aug 1, 2024
Merged

Conversation

cbjuan
Copy link
Member

@cbjuan cbjuan commented Jul 29, 2024

Summary

Fixes #22

This PR enables a programmatic way to setup the timeout for the max polling time. Also, sets up the default value to 300s instead of 600s.

Details and comments

Apart from enabling the configuration of timeouts, this PR also enables a way to define the base_url, the token or any other arg in the QiskitTranspilerService class https://github.com/Qiskit/qiskit-transpiler-service/blob/main/qiskit_transpiler_service/wrappers/base.py#L55

@cbjuan cbjuan added the enhancement New feature or request label Jul 29, 2024
@cbjuan cbjuan changed the title Enable programatic config of polling timeout Enable programmatic config of polling timeout Jul 29, 2024
@cbjuan cbjuan marked this pull request as ready for review July 31, 2024 14:27
Copy link
Contributor

@d-kremer d-kremer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cbjuan cbjuan merged commit 03b0606 into main Aug 1, 2024
7 checks passed
@cbjuan cbjuan deleted the configurable-timeouts branch August 1, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow max polling time to be configurable
2 participants