-
Notifications
You must be signed in to change notification settings - Fork 174
Support private jobs on new platform and add job.private
property
#2263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should probably hold off on this until POST /jobs actually supports the private field in the cloud channel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there are some issues with this....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks OK to me now. Have you run the test_private_option
test against the cloud provider?
Test passes on both staging and production |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good to me, I tested it locally and was able to use the private
flag on production too. My only question is how do we want to time this PR with #2239, to make sure these changes also work with the new "ibm_quantum_platform" channel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
Details and comments
Fixes #2252
Fixes #2253