Skip to content

Support private jobs on new platform and add job.private property #2263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 27, 2025

Conversation

kt474
Copy link
Member

@kt474 kt474 commented May 20, 2025

Summary

Details and comments

Fixes #2252
Fixes #2253

Copy link
Contributor

@mriedem mriedem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should probably hold off on this until POST /jobs actually supports the private field in the cloud channel.

Copy link
Contributor

@mriedem mriedem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are some issues with this....

@ElePT ElePT modified the milestone: 0.40.0 May 26, 2025
Copy link
Contributor

@mriedem mriedem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks OK to me now. Have you run the test_private_option test against the cloud provider?

@kt474
Copy link
Member Author

kt474 commented May 27, 2025

The change looks OK to me now. Have you run the test_private_option test against the cloud provider?

Test passes on both staging and production

@kt474 kt474 requested a review from ElePT May 27, 2025 14:38
Copy link
Collaborator

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me, I tested it locally and was able to use the private flag on production too. My only question is how do we want to time this PR with #2239, to make sure these changes also work with the new "ibm_quantum_platform" channel.

Copy link
Collaborator

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ElePT ElePT added this to the 0.40.0 milestone May 27, 2025
@kt474 kt474 added this pull request to the merge queue May 27, 2025
Merged via the queue into Qiskit:main with commit 475a2d7 May 27, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update docs to reflect support for private jobs Add support for private jobs
3 participants