Skip to content

Retry on 503 #2246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Retry on 503 #2246

wants to merge 2 commits into from

Conversation

kt474
Copy link
Member

@kt474 kt474 commented May 2, 2025

Summary

Should add a test

Details and comments

Fixes #2244

@kt474 kt474 marked this pull request as ready for review May 30, 2025 16:36
ElePT
ElePT reviewed Jun 3, 2025
View reviewed changes
Copy link
Collaborator

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reviewing the issue, the PR doesn't seem to be addressing:

When there is a maintenance outage we can go through the retry logic first and then show the proper error message at the end.

How can a maintenance outage be detected in this case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElePT ElePT ElePT left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add retries back on 503s
2 participants
@kt474 @ElePT