-
Notifications
You must be signed in to change notification settings - Fork 408
Add Python 3.14 testing and wheel building #2384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
34e0da8 to
b6d75ef
Compare
This change adds 3.14 to the lists of Python versions to test and to the list to build with cibuildwheel. It also marks the package as compatible with Python 3.13 and 3.14. It does not drop Python 3.9 or update the Python versions used in parts of the GitHub workflow that only use a single Python version, though doing those updates would also be a good idea.
pyproject.toml
Outdated
| manylinux-x86_64-image = "manylinux2014" | ||
| manylinux-i686-image = "manylinux2014" | ||
| skip = "pp* cp36* cp37* cp38* *musllinux*" | ||
| skip = "pp* cp36* cp37* cp38* *musllinux* cp??t-*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we'd need cp???t-* really, I think? The first valid match is cp313t-*, presumably.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, yes, I meant cp3??t-*. I was trying to copy the suggestion in the documentation here.
|
Ignoring the GPU builds: the trouble with Python 3.14 looks like Numpy upped their minimum supported glibc to 2.27 in Numpy 2.3, which is also the first Numpy to have 3.14 wheels. We're still implicitly building against glibc 2.17 because of the manylinux2014 image, so I guess we'll need to update our build image. We can potentially update the build image only for Python 3.14, since Aer wouldn't be installable (other than from-source builds of Numpy) on glibc 2.17 anyway, or skip the tests on 3.14 only. There's definitely options, but I'll take the question about the manylinux/glibc version over to Qiskit proper. |
|
Okay, that sounds good. At least from the logs we have now it looks like the gpu builds worked okay and just ran into the same numpy issue as the cpu build. |
|
It is maybe worth also checking if it is okay to drop Python 3.9 now. 3.13 is also used to install cibuildwheel. I didn't bump that to 3.14 but that would probably be fine. |
|
It's fine to drop Python 3.9 in a new Aer release - Qiskit is in the process of dropping it (Qiskit/qiskit#15139), it's just that we have some backwards-compat tests that need a rework before we can do it completely. It'll be gone in Qiskit 2.3. |
|
It looks like everything is okay moving up from Python 3.9 though we need to update the required checks in the repo settings. We need to add a release note as well but I will wait to hear what the decision is about numpy and the build image before pushing again since it triggers so much CI time. |
This change adds 3.14 to the lists of Python versions to test and to the list to build with cibuildwheel. It also marks the package as compatible with Python 3.13 and 3.14. It does not drop Python 3.9 or update the Python versions used in parts of the GitHub workflow that only use a single Python version, though doing those updates would also be a good idea.
Closes #2378