Skip to content

Upgrade to Conan2 #2372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
gadial wants to merge 81 commits into
base: main
Choose a base branch
from
Draft

Upgrade to Conan2 #2372

gadial wants to merge 81 commits into from

Conversation

@gadial
Copy link
Collaborator

@gadial gadial commented Sep 18, 2025

Summary

Details and comments

@gadial gadial marked this pull request as draft September 18, 2025 14:02
gadial added 28 commits September 18, 2025 17:25
@gadial
Added OMP to conan
09b0e18
@gadial
use CPP 17
4ef58ca
@gadial
Attempt another way to set CPP 17
535d587
@gadial
attempt to solve the libcomp.dylib issue on mac
3ea85e2
@gadial
Another mac fix attempt + try to make output more verbose
0862889
@gadial
Remove arm64 specific conan<2.0.0 related hack
68b468e
@gadial
Replace conanfile.txt by conanfile.py and try to increace cibuildwhee…
5cf7f73 
…l verbosity
@gadial
Attempted fixes for windows and arm64, and trying to adjust cbuildwhe…
717cbd5 
…el verbosity
@gadial
Typo fix + attempt to fix the windows error directly in the conanfile.py
7a00503
@gadial
remove generators since we explicity add generate()
948fcca
@gadial
another attempt at windows fix
1e507de
@gadial
another attempt at windows fix
534677e
@gadial
trying windows fix via cache_variables
52fb6f7
@gadial
Another attempt at fixing windows and arm64 problems
015cc03
@gadial
typo fix
29e5be8
@gadial
Attempt to fix the new macos and windows problems
95e4bee
@gadial
Another fix attempt
557e25b
@gadial
Remove obsolete pybind hack
03a1f19
@gadial
Attempt to completely remove the probably-obsolete macos omp-dylib ha…
12f9dbc 
…ck, and excplitly add pybind to conan
@gadial
Drop windows 32 bit build and fix for pybind command
b834cff
@gadial
Small cmake fix
fe63ca8
@gadial
Remove the remaining traces of maybe_load_openmp
8c03a10
@gadial
Bugfix in JSON loading incompatability with new lib version + fix in …
079be81 
…setup.py to enable debug mode compilation
@gadial
Updated the way vectors from cpp are converted to numpy arrays
47ee3ef
@gadial
Merge branch 'main' into conan_2_update
c6ce551
@gadial
Add debug prints for conan's profile generation
5755792
@gadial
Fix for the remaining CPP->numpy array conversions and linting
ac0a2e7
@gadial
Add the new conanfile.py to the manifest
571fa9f
gadial added 30 commits October 12, 2025 11:57
@gadial
Upgrade thrust version (this was one of the main motiviations for thi…
9d9df78 
…s PR)
@gadial
Seems like only thrust 1.17.x is availble for conan 2
0afdc25
@gadial
Attempt to modernize the now obsolete CUDA handling
96aebe7
@gadial
pick openmp package based on compiler, not system
9eeef63
@gadial
only llvm-openmp is available, so keep previous code and try to use l…
7d6d2ac 
…lvm-openmp in cmakelists
@gadial
Forgot to restore the conanfile
41e7314
@gadial
Maybe we only need to link llvm-openmp?
7680aed
@gadial
Removing explicit linking of llvm-openmp, it seems to be a deadend al…
c2c4e6e 
…though we require it specifically
@gadial
For Linux builds: try to enforce 64 bit in setup.py
8e13ac3 
For wheel-gpu: try to install presumebly missing cuda libraries
@gadial
It seems conan has both s:b and s:h params; try to use s:b to convey …
ef72ce1 
…the need for 64 bits build
@gadial
wheel-gpu attempted fix: Try to update CUDA12 pacakges to newer versi…
c52c590 
…on since I suspect the old version is missing headers
@gadial
Attempt to explicitly run conan in windows tests (due to missing omp …
510da97 
…headers; we try to be closer to how cibuildwheel works since this already succeeds)
@gadial
Another attempt to make cibuildwheel use a 64-bit compiler
595dbb1
@gadial
Need to generate conan profile before running install
197ccfe
@gadial
attempt an alternative way to obtain AER_PYTHON_CUDA_ROOT by running …
ee1a935 
…python directly in cmakelists
@gadial
CXX dirs messed the windows build; try to move to pyproject.toml for …
3b998ad 
…linux cibuildwheel runs only
@gadial
fix syntax error
c05a38f
@gadial
Removing the GCC dirs, this looks like a dead end
52a7dbd
@gadial
Attempt different setup of PYTHON_SITE_PATH
1b54fda
@gadial
Try to add the cuquantum includes also to the bindings.cc compilation…
61f2636 
… step
@gadial
Try adding the AER_THRUST_CUDA flag whenever CUDA is used, to avoid t…
fc2a83d 
…he ""multi_gpu" is undefined" error
@gadial
Linux tests have a missing OMP problem, maybe we need the AER_CMAKE_O…
a17ff82 
…PENMP_BUILD flag?
@gadial
Trying to force conan to regenerate profile in case it got things wro…
dff944b 
…ng the first time
@gadial
Adding debug print in setup.py; we're trying to understand why conan …
50b6497 
…picks the 32-bit build system (which cannot compile the fmt package)
@gadial
More debug prints and trying to conditionally set CC and CXX for linu…
390d749 
…x cibuildwheel run (to try to force 64 bit compilation)
@gadial
Try to ensure CC and CXX pass-through to the cibuildwheel enviornment
95f41f6
@gadial
Additional debug prints to understand why gcc detection fails on cibu…
eac18fd 
…ildwheel
@gadial
Remove injected CXX and CC values - this seems like a deadend, we mig…
9d7322d 
…ht have to switch container somehow
@gadial
Remove i686 - we are unable to support it in conan2
12b8839
@gadial
remove i686 from another part of the file
3bd10d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@gadial