Fix for https://github.com/Qiskit/qiskit-aer/issues/2286 #2298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gadial
approved these changes
Feb 9, 2025
Collaborator
gadial
left a comment
gadial
left a comment
There was a problem hiding this comment.
LGTM. Thank you for doing this.
Collaborator
|
@aromanro we want to merge this PR but need you to update the branch or enable admin edits. Could you please do this? |
Collaborator
|
Thanks! It seems we have general cleanup to do before we'll be able to merge PR's again... Will do it in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
MPS simulator had global bond dimension and singular values truncation threshold
Details and comments
Moved the settings from
MPS_Tensorinto the internalState, but now without thestaticspecifier. For details, see: #2286