Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tests into package to include them into distribution #108

Merged
merged 10 commits into from
Jun 3, 2022

Conversation

Dominik-Vogel
Copy link
Member

Moving tests to test folder.

@jenshnielsen
Copy link
Contributor

I think the problem is that there is no explicit broadbean in the calls to pytest.

e.g.

pytest --cov=broadbean --cov-report xml --hypothesis-profile ci

should be

pytest --cov=broadbean --cov-report xml --hypothesis-profile ci broadbean

@trevormorgan
Copy link
Contributor

Tried running locally but I can't recreate the test failure on my machine, @Dominik-Vogel we can dig into this when we chat tomorrow morning.

@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2022

Codecov Report

Merging #108 (c57a132) into master (0e57973) will increase coverage by 80.07%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master     #108       +/-   ##
===========================================
+ Coverage    0.00%   80.07%   +80.07%     
===========================================
  Files           8       15        +7     
  Lines        1494     2359      +865     
===========================================
+ Hits            0     1889     +1889     
+ Misses       1494      470     -1024     
Impacted Files Coverage Δ
broadbean/tests/conftest.py 100.00% <ø> (ø)
broadbean/tests/test_awgfilegeneration.py 98.57% <ø> (ø)
broadbean/tests/test_blueprint.py 100.00% <ø> (ø)
broadbean/tests/test_sequence.py 100.00% <ø> (ø)
broadbean/tests/test_subsequences.py 100.00% <ø> (ø)
broadbean/tests/test_element.py 100.00% <100.00%> (ø)
broadbean/tests/test_forging.py 96.59% <100.00%> (ø)
... and 11 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@trevormorgan trevormorgan added this to the version 0.11.0 milestone Jun 3, 2022
@jenshnielsen
Copy link
Contributor

The conda test yaml also needs to be updated to explicitly include hypothesis

@trevormorgan trevormorgan merged commit b73dd8d into master Jun 3, 2022
@trevormorgan trevormorgan deleted the dv/move_tests branch June 3, 2022 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants