Valon: Fix VI_ERROR_INV_MASK bug when flushing buffer #416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: - Improve regex to take negative numbers when necessary - For multiline telnet message, write once and read all lines, instead of asking multiple times and filling the buffer - Fix typo in _set_modulation_frequency Thanks to Colin Dietrich for help with these changes
jenshnielsen
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #416 +/- ##
=======================================
Coverage 10.48% 10.49%
=======================================
Files 138 138
Lines 18380 18367 -13
=======================================
Hits 1928 1928
+ Misses 16452 16439 -13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
jenshnielsen
approved these changes
Mar 14, 2025
Collaborator
jenshnielsen
left a comment
jenshnielsen
left a comment
There was a problem hiding this comment.
Changes looks good. Will just wait to see if it can be verified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
Thanks to Colin Dietrich for help with these changes
This addresses the error in #393 for a Valon 5015, however I don't have a Valon 5019 to test with.
I think that this improves on PR #338 (the part modifying the Valon), which has a change which successfully clears the error, however it does not clear the IO buffers correctly, so if you were to successively run the
Valon5015.statusandValon5015.idget commands, you would see the wrong output.Tested on a Valon 5015 running FW 2.0a which is the latest at time of writing (https://www.valontechnology.com/5015users/5015.htm)