Skip to content

Added the bounds of the dc_slew_rate_V_per_s parameter of the QDAC #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 22, 2025
Merged
2 changes: 2 additions & 0 deletions docs/changes/newfragments/401.improved
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Added the bounds of the dc_slew_rate_V_per_s parameter of the QDAC #401
The QDAC has a limitation in the bounds of the slew rate (0.01 V/s to 2e7 V/s), this change sets these bounds in the parameter of the QDAC.
3 changes: 2 additions & 1 deletion src/qcodes_contrib_drivers/drivers/QDevil/QDAC2.py
Original file line number Diff line number Diff line change
Expand Up @@ -1508,7 +1508,8 @@ def __init__(self, parent: 'QDac2', name: str, channum: int):
unit='V/s',
set_cmd='sour{1}:volt:slew {0}'.format('{}', channum),
get_cmd=f'sour{channum}:volt:slew?',
get_parser=float
get_parser=float,
vals=validators.Numbers(0.01, 2e7)
)
self.add_parameter(
name='read_current_A',
Expand Down
8 changes: 8 additions & 0 deletions tests/QDevil/test_sim_qdac2_source_dc.py
Original file line number Diff line number Diff line change
Expand Up @@ -176,3 +176,11 @@ def test_dc_abort(qdac): # noqa
qdac.ch02.dc_abort()
# -----------------------------------------------------------------------
assert qdac.get_recorded_scpi_commands() == ['sour2:dc:abor']

@pytest.mark.parametrize('u', [0.001, 2e8])
def test_invalid_dc_slew_rate(u, qdac): # noqa
# -----------------------------------------------------------------------
with pytest.raises(ValueError) as error:
qdac.ch01.dc_slew_rate_V_per_s(u)
# -----------------------------------------------------------------------
assert f'{u} is invalid' in repr(error)
Loading