Skip to content

Conversation

@thealohaprotocal
Copy link
Contributor

@astafan8 and @jenshnielsen could you please have a look.

@astafan8 astafan8 self-assigned this Feb 21, 2025
@astafan8 astafan8 enabled auto-merge February 21, 2025 16:05
@jenshnielsen
Copy link
Collaborator

@thealohaprotocal sorry for the delayed response. Your 2 other prs have landed. This one has 2 minor issues.

/home/runner/work/Qcodes_contrib_drivers/Qcodes_contrib_drivers/docs/examples/OxfordInstruments/ITC_503.ipynb: WARNING: document isn't included in any toctree

The OxfordInstruments folder needes to be added along with the other foldders to the index.rst file in the folder above for this notebook to become part of the docs.

There are some missing type annotations. Can you add these?

Run mypy src
src/qcodes_contrib_drivers/drivers/SwabianInstruments/private/time_tagger.py:67:17: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs  [annotation-unchecked]
src/qcodes_contrib_drivers/drivers/OxfordInstruments/ITC503.py:27:9: error: Need type annotation for "_values" (hint: "_values: dict[<type>, <type>] = ...")  [var-annotated]
src/qcodes_contrib_drivers/drivers/OxfordInstruments/ITC503.py:[14](https://github.com/QCoDeS/Qcodes_contrib_drivers/actions/runs/13859013079/job/38782545157?pr=395#step:7:15)6:5: error: Missing return statement  [return]
src/qcodes_contrib_drivers/drivers/OxfordInstruments/ITC503.py:158:5: error: Missing return statement  [return]
src/qcodes_contrib_drivers/drivers/OxfordInstruments/ITC503.py:170:5: error: Missing return statement  [return]
src/qcodes_contrib_drivers/drivers/Horiba/Horiba_FHR.py:38:9: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs  [annotation-unchecked]
Found 4 errors in 1 file (checked 207 source files)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants